Summary: | kget-4.4.90 fails to compile bittorrent plugin | ||
---|---|---|---|
Product: | [Applications] kget | Reporter: | Dennis Schridde <heri+kde> |
Component: | torrent | Assignee: | KGet authors <kget> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | robert |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Gentoo Packages | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Dennis Schridde
2010-06-27 11:31:59 UTC
The problem is that we are depending on the stable libktorrent until we are branched... Now, there would be the possibility of adding a version check, but in FindLibKTorrent.cmake there is no version set... so well, I should work on a fix for anything post-4.5... Lukas Ok the compilation is fixed in trunk again... still I need to work on the version check though... Lukas And it's broken again, because libktorrent just removed the ChunkSelectorInterfaceFactory and replaced it with a new StreamingChunk interface.... Which libktorrent do you use? trunk or something else? Lukas Yes, I'm using trunk for both kdenetwork and libktorrent (from extragear-network). It works fine if I use libktorrent from stable or if I comment out the bittorrent plugin in transfer-plugins/CMakeLists.txt. I would try to put a patch together, but the changes to the interface seem pretty major and I'm short on time right now (I'm still grading midterms), so if someone who is more familiar with the code could look at it, that would be great. Yeah, the real deal is to add version checks for libktorrent and support all versions possible... (needs changes in libktorrent as well though) Lukas It is fixed in trunk already... since this was code which wasn't really needed I won't add a version check at the moment... (still have that planned and looked into some bits already though :)) Lukas |