Bug 242764

Summary: Use square photos for contacts
Product: [Applications] kaddressbook Reporter: Florian <floeschie>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: chrschmitt, tokoe
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Ubuntu   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: kdepimlibs square photos patch

Description Florian 2010-06-25 11:14:23 UTC 
Version:           unspecified (using KDE 4.4.2) 
OS:                Linux

I'm syncing my contacts with Memotoo and from Memotoo to Google, as the Akonadi Google Sync plugin doesn't work well. Google and Memotoo use square contact photos, and so does my Android smartphone. However, KAdressbook uses upright photos (portrait style), so everytime I add a photo in KAdressbook it gets squeezed in Google/Android. As most of devices and services use square photos (even KAddressbook contact list), please use square photos in KAdressbook, too.

Reproducible: Always

Steps to Reproduce:
1. add a photo in kontact (kaddressbook)
2. sync to Memotoo
3. sync from Memotoo to Google

Actual Results:  
Photo gets squeezed in Google

Expected Results:  
Kontact/KAddressbook should crop fotos to square size

OS: Linux (x86_64) release 2.6.32-22-generic
Compiler: cc
Comment 1 Christian Schmitt 2010-07-02 09:41:11 UTC 
I would rather call this a bug than a wish. I have a similar problem syncing to Google and to my android phone. The photo should be square, like android and Google contacts do it. It is probably even a vCard standard? In the current state I get no photo showing up at all. Maybe it's another reason though.
Comment 2 Christian Schmitt 2010-07-02 15:56:56 UTC 
Created attachment 48543 [details]
kdepimlibs square photos patch

I did some research and found the place where to change it. The patch is attached. I dunno if it's 100% perfect, but at least it makes the photo sync work here.
Comment 3 Christian Schmitt 2010-07-02 17:48:57 UTC 
Comment on attachment 48543 [details]
kdepimlibs square photos patch

The patch applies to kdepimlibs
Comment 4 Tobias Koenig 2010-07-25 09:30:34 UTC 
SVN commit 1154335 by tokoe:

Use square photo and logo to be compatible with many other
PIM services. This also avoids squeezed images inside the list view
in KAddressBook.

Thanks to papillon81 (Christian Schmitt?) for the patch!

BUG: 242764


 M  +1 -1      contactgroupviewer.cpp  
 M  +1 -1      contactviewer.cpp  
 M  +3 -3      editor/imagewidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1154335