| Summary: | Artefacts while rotating thick lines | ||
|---|---|---|---|
| Product: | [Applications] koffice | Reporter: | BKrev <krevert> |
| Component: | general | Assignee: | KOffice Bug Wranglers <koffice-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | t.zachmann |
| Priority: | NOR | ||
| Version: | git | ||
| Target Milestone: | --- | ||
| Platform: | Arch Linux | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Attachments: | Screenshot | ||
The artefact are not shown when the shape(line) is not rotated. So the bouding box returns the correct size. The bug only happens when the e.g. the shape is rotated. Looks more like a bug in the move tool in case the shapes are rotated. As the bounding box is also used for aligning objects modifying the bounding box is not an option. I did some more testing and it looks more like that the bounding box is not correct in case the shape is rotated. The boudingbox of path shapes is indeed wrong, its easy to see by inserting any sort of path shape and making the border really large. The default tool draws the outline of the shape in place that doesn't change when the border grows, and as such a big chunk of the actual content falls outside of the bounding box. The full shape, including the border, has to be contained in the bounding box. Notice that its easier to see redrawin artifacts if you have two views open and the shape only selected in one of the two views. Rotate it and the other view will show more artifacts. SVN commit 1208879 by zander: Fix bounding rect calculation BUG:242612 M +6 -14 KoPathShape.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1208879 |
Created attachment 48269 [details] Screenshot Version: svn (using KDE 4.4.4) OS: Linux Rotating thick lines causes artefacts. Reproducible: Didn't try Steps to Reproduce: 1.) Create a line 2.) Make it huge 3.) Rotate it This solution seems to work: =================================================================== --- KoPathShape.cpp (Revision 1138839) +++ KoPathShape.cpp (Arbeitskopie) @@ -24,6 +24,7 @@ #include "KoPathPoint.h" #include "KoPointGroup.h" #include "KoShapeBorderModel.h" +#include "KoLineBorder.h" #include "KoViewConverter.h" #include "KoPathShapeLoader.h" #include "KoShapeSavingContext.h" @@ -395,6 +396,14 @@ QRectF clipRect = filterEffectStack()->clipRectForBoundingRect(QRectF(QPointF(), size())); bb |= transform.mapRect(clipRect); } + + //remove artefacts + KoLineBorder *lineBorder = dynamic_cast<KoLineBorder *>(border()); + if (lineBorder) { + qreal halfWidth = lineBorder->lineWidth()/2; + bb.adjust(-halfWidth, -halfWidth, halfWidth, halfWidth); + } + return bb; }