Summary: | KHotNewStuff doesn't copy downloaded file to target directory | ||
---|---|---|---|
Product: | [Frameworks and Libraries] kdelibs | Reporter: | Peter Grasch <me> |
Component: | knewstuff | Assignee: | Jeremy Whiting <jpwhiting> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | gladhorn, me |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Microsoft Windows | ||
OS: | Microsoft Windows | ||
Latest Commit: | Version Fixed In: |
Description
Peter Grasch
2010-06-12 10:31:21 UTC
SVN commit 1159468 by gladhorn: Use KUrl::toLocalFile instead of urlOrPath which should fix installation on windows. backport r1159467 BUG: 241523 M +2 -3 installation.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1159468 This is not yet fixed (for me at least). On line 480 the file is renamed: success = file.rename(QUrl(installpath).toLocalFile()); If I change this to that: success = file.rename(installpath); It installs fine. I added some debug output and am recompiling right now... Ok there seems to be a problem when using QUrl. I added this debug code: http://pastebin.com/E3NGPfuH Which produces these log messages: http://pastebin.com/VmASWx71 QUrl(installpath).toLocalFile() returns an empty string. Changing success = file.rename(QUrl(installpath).toLocalFile()); to success = file.rename(KUrl(installpath).toLocalFile()); (QUrl -> KUrl) fixes the bug for me. Regards, Peter Do you have an account? if so please commit your fix. else I can do it. SVN commit 1175372 by grasch: Bugfix: Copying installed files to target directory was broken on Windows BUG: 241523 M +1 -1 installation.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1175372 Commited and backported to the 4.5 branch. My first commit(s) to the KDE svn :D |