Bug 241384

Summary: KWin should use best fitting icon size
Product: [Plasma] kwin Reporter: Unknown <null>
Component: generalAssignee: KWin default assignee <kwin-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: aseigo
Priority: NOR    
Version: 0.2   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 4.4.5
Sentry Crash Report:
Attachments: Small Opera icon

Description Unknown 2010-06-11 08:51:55 UTC 
Version:           0.1 (using Devel) 
OS:                Linux

In system settings set the following task swither layout options:
Vertical, compact, show selected items, upper, big icons (20%, 20%).

Now try to switch among windows. The appearing list has a big icon on top but that icon is the small variant and enlarged to the current size.

Reproducible: Always




OS: Linux (x86_64) release 2.6.31.12-0.2-desktop
Compiler: gcc
Comment 1 Unknown 2010-06-11 08:52:26 UTC 
Created attachment 47887 [details]
Small Opera icon
Comment 2 Martin Flöser 2010-06-11 20:26:24 UTC 
KWin only reads the icons in sizes 32x23 and 16x16 from the window (probably still from times when windows did not have more than 32x32 icons). I think it makes sense to read all available icon sizes and use the best fitting one when we paint an icon.

As that requires quite some changes I think it won't make it into 4.5.
Comment 3 Martin Flöser 2010-06-12 08:48:38 UTC 
SVN commit 1137263 by graesslin:

Make icon sizes 64x64 and 128x128 available in KWin and use it in TabBox for large icon modes.
So no more ugly upscaling.
BUG: 241384
FIXED-IN: 4.4.5



 M  +35 -2     client.cpp  
 M  +16 -1     client.h  
 M  +28 -2     group.cpp  
 M  +2 -0      group.h  
 M  +2 -2      kcmkwin/kwintabbox/previewhandlerimpl.cpp  
 M  +1 -1      kcmkwin/kwintabbox/previewhandlerimpl.h  
 M  +2 -2      tabbox.cpp  
 M  +1 -1      tabbox.h  
 M  +15 -2     tabbox/clientitemdelegate.cpp  
 M  +2 -1      tabbox/tabboxhandler.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137263
Comment 4 Martin Flöser 2010-06-12 08:49:37 UTC 
SVN commit 1137264 by graesslin:

Forward port rev 1137263:
Make icon sizes 64x64 and 128x128 available in KWin and use it in TabBox for large icon modes.
So no more ugly upscaling.
CCBUG: 241384

 M  +35 -2     client.cpp  
 M  +16 -1     client.h  
 M  +28 -2     group.cpp  
 M  +2 -0      group.h  
 M  +2 -2      kcmkwin/kwintabbox/previewhandlerimpl.cpp  
 M  +1 -1      kcmkwin/kwintabbox/previewhandlerimpl.h  
 M  +2 -2      tabbox.cpp  
 M  +1 -1      tabbox.h  
 M  +15 -2     tabbox/clientitemdelegate.cpp  
 M  +2 -1      tabbox/tabboxhandler.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1137264