Summary: | Plasma crashes on startup | ||
---|---|---|---|
Product: | [Unmaintained] plasma4 | Reporter: | Vit Pelcak <vit> |
Component: | widget-folderview | Assignee: | Plasma Bugs List <plasma-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | asraniel, notmart |
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | openSUSE | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
Vit Pelcak
2010-06-10 14:37:27 UTC
Marco is it ok to commit ? Index: plasma/applets/folderview/folderview.cpp =================================================================== --- plasma/applets/folderview/folderview.cpp (révision 1136104) +++ plasma/applets/folderview/folderview.cpp (copie de travail) @@ -883,7 +883,9 @@ m_listView->setDrawShadows(m_drawShadows); m_listView->setIconSize(iconSize()); m_listView->setWordWrap(m_numTextLines > 1); - m_iconView->setTextLineCount(m_numTextLines); + if ( m_iconView ) { + m_iconView->setTextLineCount(m_numTextLines); + } } void FolderView::updateIconViewState() Nicolas: the patch seems ok. did you check if it actually fixes the issue? were you able to reproduce? (if m_iconview was instead a dangling pointer this isn't going to resolve it) anyways, i think you should commit. maybe still check with fredrik SVN commit 1136767 by aseigo: when initializing the applets, restore from config, then init, then flush the containment's constraints, then flush the applet's constraints. ensures that constraint events always happen after both restoration and initialization of the applet BUG:241298 M +8 -2 containment.cpp M +0 -1 corona.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1136767 |