Bug 240916

Summary:	Question for web authentification: Better button names [patch]
Product:	[Applications] digikam	Reporter:	Michael G. Hansen <mike>
Component:	Plugin-WebService-Flickr	Assignee:	Digikam Developers <digikam-bugs-null>
Status:	RESOLVED FIXED
Severity:	minor	CC:	c2tarun, caulier.gilles, petri.damsten
Priority:	VLO	Keywords:	junior-jobs
Version:	5.6.0
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	2.2.0
Sentry Crash Report:
Attachments:	this is the diff between older source code and the source code with my changes. patch of kipi-plugins_1.9.0-1ubuntu1

Description Michael G. Hansen 2010-06-06 18:41:21 UTC

Version:           1.3.0 (using Devel) 
OS:                Linux

Launch the flickr export plugin. A browser window opens and a dialog box with this text appears: "Please follow the instructions in the browser window, then return to press Yes if you are authenticated, or No otherwise." IMHO, it would be more straightforward to see which button to press if the buttons were labeled "I am authenticated" and "I am not authenticated".

Reproducible: Always

Comment 1 Michael G. Hansen 2011-02-09 20:36:22 UTC

Have a look at this blog post:

http://agateau.wordpress.com/2011/01/21/common-user-interface-mistakes-in-kde-applications-part-3-message-boxes/

Michael

Comment 2 Tarun Kumar Mall 2011-03-26 15:25:19 UTC

Created attachment 58356 [details]
this is the diff between older source code and the source code with my changes.

I tried to fix the bug mentioned here. This is my first time so it may not be perfect :( I am looking forward for the reviews and I'll try to fix any problems.
Thank you.

Comment 3 caulier.gilles 2011-03-26 16:07:07 UTC

Thanks for your patch.

I can take a look before 2.0.0 beta 4

Gilles Caulier

Comment 4 Tarun Kumar Mall 2011-03-26 17:34:04 UTC

Created attachment 58360 [details]
patch of kipi-plugins_1.9.0-1ubuntu1

Sorry my previous patch is not working properly :(
Here is my new patch.

Comment 5 caulier.gilles 2011-03-26 18:23:31 UTC

It's always better to create patch against 2.0.0 source code from git repository, because i will apply it for 2.0.0. Not new 1.x release is planed now.

http://www.digikam.org/drupal/contrib

Gilles Caulier

Comment 6 Petri Damstén 2011-09-13 07:45:00 UTC

Some notes:
- Text still says to press Yes or No although buttons are renamed.
- Buttons could have icons (Yes/No button icons?).
- All similar dialogs in kipi plugins should be consistent.

Comment 7 Petri Damstén 2011-09-27 07:28:21 UTC

Git commit af0daab4fb44ebbbeed31b114b72cef9bbb0b8f9 by Petri Damstén.
Committed on 27/09/2011 at 09:20.
Pushed by pdamsten into branch 'master'.

Question for web authentification: Better button names
BUG:240916

M  +6    -3    flickrexport/flickrtalker.cpp

http://commits.kde.org/kipi-plugins/af0daab4fb44ebbbeed31b114b72cef9bbb0b8f9