Bug 240817

Summary: Jovie fails to build with linking errors
Product: kttsd Reporter: Robert Marmorstein <robert>
Component: generalAssignee: Jeremy Whiting <jpwhiting>
Status: RESOLVED FIXED    
Severity: minor    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Port K3Process to QProcess

Description Robert Marmorstein 2010-06-05 17:45:56 UTC
Created attachment 47708 [details]
Port K3Process to QProcess

Version:           unspecified (using Devel) 
OS:                Linux

When trying to build latest kdeaccessibility trunk, the compile fails with:

Linking CXX executable jovie
CMakeFiles/jovie_bin.dir/jovie.o: In function `Jovie::showManagerDialog()':                                                                                                         
/var/abs/local/eth-os/sources/KDE/kdeaccessibility/jovie/jovie/jovie.cpp:455: undefined reference to `KRun::runCommand(QString const&, QWidget*)'
CMakeFiles/jovie_bin.dir/ssmlconvert.o: In function `SSMLConvert::transform(QString const&, QString const&)':
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:231: undefined reference to `K3Process::K3Process(QObject*)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:232: undefined reference to `K3Process::operator<<(char const*)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:233: undefined reference to `K3Process::operator<<(char const*)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:233: undefined reference to `K3Process::operator<<(QString const&)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:233: undefined reference to `K3Process::operator<<(char const*)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:234: undefined reference to `K3Process::operator<<(QString const&)'
/var/abs/local/ethos/sources/KDE/kdeaccessibility/jovie/jovie/ssmlconvert.cpp:234: undefined reference to `K3Process::operator<<(QString const&)'
collect2: ld returned 1 exit status


Reproducible: Always

Steps to Reproduce:
Obtain latest trunk.
Try to build it.
Fail.

Actual Results:  
I see the errors described above.

Expected Results:  
Jovie compiles flawlessly.

There are two problems.  The first is that the CMakeLists.txt file does not link against the KIO libraries.  This is trivial to fix.

The second problem is that K3Process is deprecated and the KDE3 compatibility libraries have been commented out in the CMakelists.txt file.  Please see the attached patch that ports K3Process to QProcess.
Comment 1 Jeremy Whiting 2010-06-07 14:17:53 UTC
Just curious, what version of kdelibs are you trying to build against? I am able to build and link it just fine here on 2 different machines.  That said I like your patch and will commit it shortly, moving away from KDE3 compatibility is always a good thing :)
Comment 2 Jeremy Whiting 2010-06-07 15:11:47 UTC
Committed your patch in svn rev 1135488
Comment 3 Robert Marmorstein 2010-06-07 17:04:06 UTC
Hi Jeremy,

I use latest trunk for everything, including kdelibs.  That may sound crazy, but I enjoy being on the bleeding edge...


Thanks for committing the patch so quickly!
Comment 4 Jeremy Whiting 2010-06-07 17:32:42 UTC
I use latest trunk on everything too, I'm baffled why I didn't get the
error, but it's ok, no worries.  Thanks again for the patch.

Jeremy

On Mon, Jun 7, 2010 at 9:04 AM, Robert Marmorstein
<rmmarm@sdf.lonestar.org>wrote:

> https://bugs.kde.org/show_bug.cgi?id=240817
>
>
>
>
>
> --- Comment #3 from Robert Marmorstein <rmmarm sdf lonestar org>
>  2010-06-07 17:04:06 ---
> Hi Jeremy,
>
> I use latest trunk for everything, including kdelibs.  That may sound
> crazy,
> but I enjoy being on the bleeding edge...
>
>
> Thanks for committing the patch so quickly!
>
> --
> Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
> ------- You are receiving this mail because: -------
> You are the assignee for the bug.
>