Summary: | Graphical path picker in dialog to handle unwritable destination path upon accepting transfer is broken | ||
---|---|---|---|
Product: | [Applications] konversation | Reporter: | Eike Hein <hein> |
Component: | dcc | Assignee: | Bernd Buschinski <b.buschinski> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | cledwon, konversation-devel |
Priority: | NOR | ||
Version: | Git | ||
Target Milestone: | --- | ||
Platform: | Compiled Sources | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Eike Hein
2010-06-03 21:09:58 UTC
commit cc9e57f94d6f52bef4b946c3e5b63eb6a34aed01 Author: Eike Hein <hein@kde.org> Date: Fri Jun 4 19:02:36 2010 +0200 Fix resume dialog file picker complaining about not yet existing paths. BUG:240645 Also don't lose the file name across directory changes in the file picker. diff --git a/ChangeLog b/ChangeLog index 73f2a91..6fad0a4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,16 @@ Changes since 1.3-beta1: the state of the list control buttons. * After adding a new item to one of the server or channel lists in "Edit Network" dialogs, that item will now be selected. +* Fixed a bug causing the file dialog for selecting a new target directory + and file name for an incoming DCC file transfer in the event that the + default path is not writable to complain about being unable to find the + file after clicking "OK" when no file of the chosen name at the chosen + location exists already. +* Fixed a bug causing the file dialog for selecting a new target directory + and file name for an incoming DCC file transfer in the event that the + default path is not writable to lose the file name written in the "Lo- + cation" field (by default, the original file name) when changing the + current directory. Changes from 1.2.3 to 1.3-beta1: diff --git a/src/dcc/resumedialog.cpp b/src/dcc/resumedialog.cpp index 88c24f6..e4b4963 100644 --- a/src/dcc/resumedialog.cpp +++ b/src/dcc/resumedialog.cpp @@ -19,6 +19,7 @@ #include <QVBoxLayout> #include <QHBoxLayout> +#include <KFileDialog> #include <KLocale> #include <KUrl> #include <KUrlRequester> @@ -80,6 +81,8 @@ namespace Konversation labelMessage->setText(message); m_urlreqFileURL = new KUrlRequester(m_item->getFileURL().prettyUrl(), page); + m_urlreqFileURL->setMode(KFile::File | KFile::LocalOnly); + m_urlreqFileURL->fileDialog()->setKeepLocation(true); connect(m_urlreqFileURL, SIGNAL(textChanged(const QString&)), this, SLOT(updateDialogButtons())); pageLayout->addWidget(labelMessage); commit cc9e57f94d6f52bef4b946c3e5b63eb6a34aed01 Author: Eike Hein <hein@kde.org> Date: Fri Jun 4 19:02:36 2010 +0200 Fix resume dialog file picker complaining about not yet existing paths. BUG:240645 Also don't lose the file name across directory changes in the file picker. diff --git a/ChangeLog b/ChangeLog index 73f2a91..6fad0a4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -8,6 +8,16 @@ Changes since 1.3-beta1: the state of the list control buttons. * After adding a new item to one of the server or channel lists in "Edit Network" dialogs, that item will now be selected. +* Fixed a bug causing the file dialog for selecting a new target directory + and file name for an incoming DCC file transfer in the event that the + default path is not writable to complain about being unable to find the + file after clicking "OK" when no file of the chosen name at the chosen + location exists already. +* Fixed a bug causing the file dialog for selecting a new target directory + and file name for an incoming DCC file transfer in the event that the + default path is not writable to lose the file name written in the "Lo- + cation" field (by default, the original file name) when changing the + current directory. Changes from 1.2.3 to 1.3-beta1: diff --git a/src/dcc/resumedialog.cpp b/src/dcc/resumedialog.cpp index 88c24f6..e4b4963 100644 --- a/src/dcc/resumedialog.cpp +++ b/src/dcc/resumedialog.cpp @@ -19,6 +19,7 @@ #include <QVBoxLayout> #include <QHBoxLayout> +#include <KFileDialog> #include <KLocale> #include <KUrl> #include <KUrlRequester> @@ -80,6 +81,8 @@ namespace Konversation labelMessage->setText(message); m_urlreqFileURL = new KUrlRequester(m_item->getFileURL().prettyUrl(), page); + m_urlreqFileURL->setMode(KFile::File | KFile::LocalOnly); + m_urlreqFileURL->fileDialog()->setKeepLocation(true); connect(m_urlreqFileURL, SIGNAL(textChanged(const QString&)), this, SLOT(updateDialogButtons())); pageLayout->addWidget(labelMessage); |