| Summary: | make embedded okular optional | ||
|---|---|---|---|
| Product: | [Unmaintained] rekonq | Reporter: | Kilian Lackhove <kilian> |
| Component: | general | Assignee: | Andrea Diamantini <adjam7> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | braslau, mauro.iazzi, romain.diss |
| Priority: | NOR | ||
| Version: | latest git snapshot | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Linux | ||
| Latest Commit: | http://commits.kde.org/rekonq/e80327f333e724ae394e582e358181a67fb2ff4d | Version Fixed In: | |
| Sentry Crash Report: | |||
| Attachments: | kdes filetypes /embed menu | ||
|
Description
Kilian Lackhove
2010-06-02 00:20:17 UTC
? Created attachment 47604 [details]
kdes filetypes /embed menu
*not* embedding.. sorry it was late yesterday. Currently when clicking on a link to a pdf in rekonq, rekonq shows a dialog "save as, open, cancel". On clicking "open", rekonq opens the pdf in an embedded okular. It would be great to have an option for opening the pdf in a seperate okular instance. Maybe rekonq could follow the konqueror settings in the filetypes systemsettings module (see attachment). I confirm the bug wish. I think it's actually a regression since it worked well in 0.5. In 0.5, when one clicked on a pdf link, rekonq showed a dialog "save as, open, open with (okular), cancel" (if I remember well). Like Kilian, one should have the option to open the pdf in a "non embedded fashion" cause the embedded one gives less features (no search bar, no text selection, ...). As a workaround you can remove the okular part from System Settings -> File Associations. Rekonq will correctly open the pdfs in external Okular. Of course the real solution would be to follow the setting under the embedded tab, but this makes it less urgent. It can also be done with many other types that are opened with the katepart just because they are text-based, like srt, pgn etc... (In reply to comment #5) > As a workaround you can remove the okular part from System Settings -> File > Associations. Rekonq will correctly open the pdfs in external Okular. Of > course the real solution would be to follow the setting under the embedded > tab, but this makes it less urgent. Doesn't work: Rekonq will only open pdfs in an embedded okular. I very much dislike this behavior. Thank you Git commit e80327f333e724ae394e582e358181a67fb2ff4d by Harald Sitter. Committed on 11/04/2013 at 11:51. Pushed by sitter into branch 'master'. honor filetype setting WRT embedding there are 3 distinct states a filetype can have WRT kpart embeding - always embed - never embed - do whatever the parent node does (e.g. application/foo would take the setting of application) since the logic to determine which of those it is going to be we are using a bit of code imported from konqueror deciding in a boolean fashion whether or not we are supposed to embed or not. this is particularly non- intrusive as the decision directly relates to whether a kpart is created, if not the file will simply be krun'. this change is using static functions for the imported code. rationale being that they are in fact static and not having them reflected in the header makes them all the easier to remove should a better solution arise in the future. with that in mind: while the code is copy'n'pastable it seems like a good idea to move this into some shared library in the long term such that konqueror and rekonq (and any other kpart enabled app) can use the same code. REVIEW: 109942 Related: bug 279423 M +71 -1 src/webtab/webpage.cpp http://commits.kde.org/rekonq/e80327f333e724ae394e582e358181a67fb2ff4d |