| Summary: | Amarok crashed when attempting to move read only files to the local collection [@ Collections::CollectionLocation::slotFinishRemove] | ||
|---|---|---|---|
| Product: | [Applications] amarok | Reporter: | Vasilis Vasaitis <vvasaitis> |
| Component: | Collections/Local | Assignee: | Amarok Developers <amarok-bugs-dist> |
| Status: | RESOLVED DUPLICATE | ||
| Severity: | crash | CC: | felipe.alvarez, kde, matej, mcmillanje, ralf-engels |
| Priority: | NOR | ||
| Version: | 2.3.2 | ||
| Target Milestone: | 2.4.0 | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Amarok 2.3.2 crash backtrace | ||
|
Description
Vasilis Vasaitis
2010-05-30 21:52:56 UTC
Confirmed by duplicate. *** Bug 254906 has been marked as a duplicate of this bug. *** Is this still valid with Amarok 2.3.2? Don't know about 2.3.2 but 2.3.1 still has the bug. That is the reason why I ask, this report is about 2.3.1, the latest stable is 2.3.2 It would be really helpful if somebody could test this with 2.3.2 I haven't upgraded to 2.3.2 yet, but if I find time over the weekend I'll perform the upgrade and give it a go! This might not be the most reproducible crash though... I have tested Amarok version 2.3.2, inside a VirtualBox VM, with a Mandriva 2010.1 guest. First copied, to the VM, the files and directories that were giving problems with Amarok version 2.3.1. Then tried to organize those files, using the same options. It worked. There was no crash and the files were renamed as intended. Wanting to test it a bit more, I "chmod -R a-w *" the music collection and retried the "Organize Files" operation. Now it crashed, just like I described before, in https://bugs.kde.org/show_bug.cgi?id=254906 So, Amarok version 2.3.2 seems to have the same bug as version 2.3.1, and a easy way to trigger it is to make the files read only. Hope this helps. Will had backtrace of crash as attachment next. Created attachment 52822 [details]
Amarok 2.3.2 crash backtrace
(In reply to comment #7) > I have tested Amarok version 2.3.2, inside a VirtualBox VM, with a Mandriva > 2010.1 guest. > > First copied, to the VM, the files and directories that were giving problems > with Amarok version 2.3.1. Then tried to organize those files, using the same > options. It worked. There was no crash and the files were renamed as intended. > > Wanting to test it a bit more, I "chmod -R a-w *" the music collection and > retried the "Organize Files" operation. Now it crashed, just like I described > before, in https://bugs.kde.org/show_bug.cgi?id=254906 > > So, Amarok version 2.3.2 seems to have the same bug as version 2.3.1, and a > easy way to trigger it is to make the files read only. Hope this helps. Sorry, but how on earth do you expect Amarok to be able to perform an "Organize Files" action if those files are not writable? Organize Files moves files from their first location, making those read only makes that action impossible. Collection files should never bee read only anyway. I agree that it shouldn't crash, though, and give an error message instead. Please file a different report for that. Oops, forget the last line, since I changed the bug title. Sorry for the noise. First, it should not crash. Second, on the original collection all the files and directories have write permissions, and it still crashes. Third, the crash backtrace is very similar in both cases, so the cause of the crash is most likely the same. Opening a new report would most likely be counter-productive. That is not what you said in your description, you only triggered the crash by changing the permission to read-only, and normally user files should never be read-only in the first place. Also you didn't read my last comment :) Myriam: A file does not need to be writable in order to move it to a different location, as the operation does not change the file contents. What has to be writable is the source and destination directory, but not the file itself.
By the way, thanks for doing all this triaging work!
Pedro: Instead of your "chmod -R" command, out of curiosity and if it's not too much trouble, can you try if it's the files being read-only, or the directories being read-only, that's causing the crash? You can achieve that with these commands, respectively:
find collection_dir/ -type f -exec chmod a-w \{} +
find collection_dir/ -type d -exec chmod a-w \{} +
Cheers,
Vasilis
I did the following:
$ chmod -R u+rwX ~/Music
$ find ~/Music/ -type f -exec chmod a-w '{}' ';'
Tried "Organize Files" and Amarok didn't crash.
$ chmod -R u+rwX ~/Music
$ find ~/Music/ -type d -exec chmod a-w '{}' ';'
$ chmod u+rwX ~/Music
Tried "Organize Files" and Amarok crashed.
The last chmod was needed because Amarok (correctly) warned that the collection directory was read only and refused to do any "Organize FIles".
*** Bug 255385 has been marked as a duplicate of this bug. *** *** Bug 258068 has been marked as a duplicate of this bug. *** *** This bug has been marked as a duplicate of bug 236030 *** |