Summary: | ktorrent plasmoid memory leak | ||
---|---|---|---|
Product: | [Applications] ktorrent | Reporter: | Amichai Rothman <amichai2> |
Component: | general | Assignee: | Joris Guisson <joris.guisson> |
Status: | RESOLVED FIXED | ||
Severity: | normal | ||
Priority: | NOR | ||
Version: | unspecified | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: |
Description
Amichai Rothman
2010-05-27 00:04:15 UTC
SVN commit 1131207 by guisson: Fix memory leak in plasma dataengine BUG: 238948 M +1 -0 ChangeLog M +2 -0 plasma/dataengine/torrentdbusinterface.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1131207 Thanks for the quick response! I don't know if this happens in practice, but the decode() method can return NULL or throw an exception, so it might be necessary to add a NULL check before the delete, as well as before the first time the return value is dereferenced (the line following decode()). Scratch that first option - delete NULL is guaranteed to do nothing. The dereference might be a problem though (but is unrelated to the memory leak). Yeah I need to add a check for that. |