Bug 238874

Summary: Wikipedia applet remains permanently in busy state, not displaying the retrieved web page.
Product: [Applications] amarok Reporter: Alex G <gforce>
Component: Context View/WikipediaAssignee: Amarok Developers <amarok-bugs-dist>
Status: RESOLVED FIXED    
Severity: normal CC: dweeble01103, lfranchi, nzlbob2332, simon.esneault, stuffcorpse
Priority: NOR    
Version: 2.3.1-GIT   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In: 2.3.2
Sentry Crash Report:

Description Alex G 2010-05-26 12:40:38 UTC
Version:           2.3-GIT (using Devel) 
OS:                Linux

The wiki context engine does not display the page after it is retried.
The view does not time-out or return any error message if it fails to retrieve a page.

This does not appear to be a KDE/system/KIO issue which was fixed with commit http://gitorious.org/amarok/amarok/commit/8faa470ab7d96ffabae697c75a52739452542d45, from what can be seen in the debug out... see actual results below.


Reproducible: Always

Steps to Reproduce:
Start Amarok, Enable the Wikipedia applet in the context-view, then play an album/track in the playlist of a well-known artist. The Wiki applet does not load the web page, instead the "busy thing" is displayed permanently.

Actual Results:  
Remains stuck with the "busy thing", in other words the hourglass. The web page never loads.
Debug output seems to indicate the page was retried and the KIO job completed:
amarok:               BEGIN: void WikipediaEngine::update() 
amarok:                 BEGIN: bool EngineController::isStream() 
amarok:                 END__: bool EngineController::isStream() - Took 3.4e-05s 
amarok:                  wiki url:  "http://en.wikipedia.org/w/index.php?title=---band%29&useskin=monobook" 
amarok:               END__: void WikipediaEngine::update() - Took 0.00023s 
amarok: BEGIN: void WikipediaEngine::wikiResult(KJob*) 
amarok: END__: void WikipediaEngine::wikiResult(KJob*) - Took 0.00021s 


Expected Results:  
Time out or display the wiki page -- or report an issue attempting to retrieve the web page.

OS: Linux (x86_64) release 2.6.33-gentoo-r2
Compiler: x86_64-pc-linux-gnu-gcc
Comment 1 Myriam Schweingruber 2010-05-26 13:30:11 UTC
I can't reproduce this here with current git, KDE SC 4.4.3 on Kubuntu 10.04
Comment 2 Stephen Dunn 2010-06-11 09:40:15 UTC
I can reproduce with 2.3.1 in 4.5b2 on os11.3m7

Cheers
Steve
Comment 3 Myriam Schweingruber 2010-06-11 12:22:37 UTC
Still can't reproduce this here, using Amarok 2.3.1-git, KDE SC 4.5 beta 2 on Kubuntu 10.04 LTS. Maybe some old plasma configuration is interfering?
Comment 4 Alex G 2010-06-12 14:25:52 UTC
Still experiencing the same wiki applet problem with a fresh live Qt and kdelibs rebuild.

All other amarok applets work, including video. Haven't had much time to investigate further. Unable to reproduce 2nd workstation/Fedora Rawhide, since Amarok crashes on start-up... may try this again soon.

Some observations:
* The wiki applet used to work on build.
* It is not a networking/system issue.
* F5/reload causes an error message to be displayed "Unable to retrieve Wikipedia information: The file or folder http://en.wikipedia.org/w/index.php?......".  The URL works fine in a browser.
* Clearing out /var/tmp/kde* and /tmp/kde* didn't do the trick. Will try this again, there were open handles/fd's.
* There is one album that works immediately -- must be from cache?
Comment 5 Myriam Schweingruber 2010-06-12 15:58:53 UTC
Reopening based on comments.
Comment 6 Myriam Schweingruber 2010-06-12 15:59:16 UTC
Setting to confirmed.
Comment 7 Stephen Dunn 2010-06-13 00:47:49 UTC
Hi

I'm getting the same problem as Alex in comment 4. I think it is a different problem to that originally reported though. For some artists the plugin does work.

To me it seems to be to do with the format of the request Amarok is sending to wikipedia.

This works:

wiki url:  "http://en.wikipedia.org/w/index.php?title=Blondie%20%28band%29&useskin=monobook"

This doesn't

wiki url:  "http://en.wikipedia.org/w/index.php?title=Amy%20Winehouse%20%28band%29&useskin=monobook"

When I use a web browser to view the url's I get the wiki page for the first and the second gives the standard can't find article page. I've tested this on several bands, artists, albums with consistent results.

Could it be that including (band) in the url is causing the problem?

That's an amateurs guess anyway :)

Thanks
Steve
Comment 8 Alex G 2010-06-14 00:10:19 UTC
Had another look, and it seems the issue is more related to KUrl/kdelibs/khtml than Amarok.

The wiki will return a custom 404 page when no article is found with an index.php?title=Query.

Amarok/konqueror do not display this custom 404 page, which contains links/suggestions for alternatives.

Perhaps the applet could handle blank/non-blank HTTP 404s by doing a search instead, or at least displaying the custom 404?
Comment 9 Stephen Dunn 2010-06-15 00:16:13 UTC
I don't think this does work.

What needs to happen is the "(band)" park of the request not to be sent in the url.

For example, as per comment 7, this works: "Amy Winehouse" but this doesn't work: "Amy Winehouse (band)".

Why can't Amarok send the url request without the (band) part in it?

Thanks.
Steve

(I would like to clear the worksforme but don't have the permissions to do so).
Comment 10 Myriam Schweingruber 2010-06-15 00:41:40 UTC
Stephen, are you on Amarok 2.3.1? Then be aware that Alex as the original reporter uses Amarok 2.3.1-git which is ahead of your version. Also if doesn't seem to be an Amarok related bug, but I will ask a dev anyway.
Comment 11 Stephen Dunn 2010-06-17 09:35:11 UTC
Thanks Myriam

I was on 2.3.1 but as of today I have installed 2.3.1-GIT and have the same problem.

If not amarok can you point me towards what might be causing the problem?

Cheers
Steve
Comment 12 Myriam Schweingruber 2010-06-18 00:16:14 UTC
(In reply to comment #11)
> Thanks Myriam
> 
> I was on 2.3.1 but as of today I have installed 2.3.1-GIT and have the same
> problem.
> 
> If not amarok can you point me towards what might be causing the problem?


Please see comment #8, I don't know much more about it, and the developer of this applet is quite busy with work at the moment.
Comment 13 Rick W. Chen 2010-07-12 06:12:42 UTC
(In reply to comment #9)

The " (band)" is part of a refinement process that the applet goes through when trying to get a band/artist page. This is done so when there are ambiguities the more likely title is chosen. What should happen when a title with " (band)" appended is not found is that the next refinement should be substituted, or stop when all of them are tried.
Comment 14 Myriam Schweingruber 2010-07-12 21:32:21 UTC
*** Bug 243617 has been marked as a duplicate of this bug. ***
Comment 15 Stephen Dunn 2010-07-13 03:13:19 UTC
Now works for me with latest GIT in openSUSE factory.

Thanks
Comment 16 Myriam Schweingruber 2010-07-13 11:29:58 UTC
Yes, works in current git now.