| Summary: | dolphin rotates photos according to exif information, needs option to turn it off | ||
|---|---|---|---|
| Product: | [Applications] dolphin | Reporter: | Janet <bugzilla> |
| Component: | general | Assignee: | Peter Penz <peter.penz19> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | cfeck, kdebugs.99.urgwurz |
| Priority: | NOR | ||
| Version: | 16.12.2 | ||
| Target Milestone: | --- | ||
| Platform: | Debian unstable | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.6.0 | |
| Sentry Crash Report: | |||
|
Description
Janet
2010-05-23 22:44:25 UTC
I just got aware of that it's not only the problem of not seeing *which* photos you have to rotate, it's a huge problem that you cannot see into *which direction* you have to rotate it! So it's impossible anymore to use dolphin for working with the photos at all! Well, now that's a severe problem! Besides that the photos are shown in *wrong* orientation after rotation with imagemagick batch opration in terminal or dolphin servicemenu (e.g. kim). Drives me mad too! All photos in my huge collection that I have rotated before that dolphin "feature" are now shown in wrong orientation - or not - I cannot say if they are rotated correctly or if they are just shown rotated or shown rotated wrong or whatsoever. Please please please give the control over that back to the user and add an option to dolphin to NOT show the thumbnails rotated according to the exif info but show them as they really are! I even have turned off the option to use the thumbnails saved in the exif information - but still dolphin shows the thumbnails in an other orientation as the pictures are or not what I cannot distinguish without using an imageviewer which is "featureless" in that case. It is just confusing, very. Sorry for the troubles, but this change was made outside the scope of Dolphin in the JPEG-loader plugin. I agree that an option in Dolphin is required here, I've changed the severity of this bug from "wishlist" to "normal". Please push me again if the state of this bug has not been changed until end of October. Thanks! Push! :) SVN commit 1195350 by ppenz: Move the functionality of the JpegCreator to automatically rotate the image corresponding to EXIF to a new creator called JpegRotatedCreator. This allows the users to specify whether they want to have automatically rotated JPEGs or not. BUG: 238618 FIXED-IN: 4.6.0 M +16 -5 CMakeLists.txt M +2 -239 jpegcreator.cpp M +0 -2 jpegcreator.h A jpegcreatorhelper.cpp [License: LGPL (v2+)] A jpegcreatorhelper.h [License: LGPL (v2+)] A jpegrotatedcreator.cpp [License: LGPL (v2+)] A jpegrotatedcreator.h [License: LGPL (v2+)] A jpegrotatedthumbnail.desktop M +1 -1 thumbnail.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1195350 @Janet: I hope the current solution is sufficient, I've to admit that it is not perfect but I've currently no better idea how to solve this without introducing a "settings framework" for thumbnail-creators ;-) So now in the Previews dialog it is possible to select between "JPEG Images" and "JPEG Images (Rotated Automatically)". The not so nice things are: - When selecting both, it is undefined which creator will be taken. - When selecting "JPEG Images" and creating thumbnails and afterwards changing it to "JPEG Images (Rotated Automatically)", existing thumbnails won't get recreated. In this case you've to manually delete the .thumbnails directory :-( Peter, we should think about having settings for thumbnailers for 4.7 or so. MPlayerThumbnailer has a separate application for settings that I hadn't discovered until I looked at the source, and people are asking for options in the text thumbnailer, such as whether to break lines or simply cut them off. Not sure what other thumbnailers could need options, but you know, KDE users like to play with many knobs :) Yes, if other thumbnails need such settings too then we should really think about this for 4.7. I've added an internal TODO for me and will start with this after 4.6 has been released. If you have any suggestions (or want to do it yourself :-)) please just drop me a note! Thanks for this solution, it will help a lot! This is a workaround that can only be used in dolphin I guess? It cannot be proposed to e.g. gwenview (which also has no option to turn off auto-rotation) I suppose? > This is a workaround that can only be used in dolphin I guess?
> It cannot be proposed to e.g. gwenview
It works for all applications, that use the default thumbnail mechanism from kdelibs. But I don't know whether Gwenview uses it :-/
|