Bug 238508

Summary:	The Layout direction of System Settings is wrong in RTL env.
Product:	[Applications] systemsettings	Reporter:	Zayed Al-Saidi <zayed.alsaidi>
Component:	general	Assignee:	Rafael Fernández López <ereslibre>
Status:	RESOLVED FIXED
Severity:	normal	CC:	bcooksley, ebrahim, ereslibre, nalvarez, peter.penz19
Priority:	NOR	Keywords:	regression, rtl
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	SystemSetting in RTL mode kde 4.3 vs kde 4.5

Description Zayed Al-Saidi 2010-05-22 17:42:45 UTC

Version:           1.0 (using 4.4.76 (KDE 4.4.76 (KDE 4.5 >= 20100516)) "release 1", KDE:KDE4:UNSTABLE:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (i686) release 2.6.31.12-0.2-default

The kcm modules are starting from the left to right when the System Settings in RTL mode. They should be from right to left as in kde 4.3. Please see the attached screenshot.

How to reproduce:
1- run System Settings in RTL by : systemsettings -reverse

Comment 1 Zayed Al-Saidi 2010-05-22 17:43:53 UTC

Created attachment 43803 [details]
SystemSetting in RTL mode kde 4.3 vs kde 4.5

Comment 2 Ben Cooksley 2010-05-27 09:20:58 UTC

Affects any application which uses KCategorizedView... 

@ereslibre: Any ideas on how this regression occurred?

Comment 3 Ben Cooksley 2011-04-14 05:56:56 UTC

Rafael, could you please check this... it still exists in KDE 4.6 + Trunk...

Comment 4 Rafael Fernández López 2011-04-24 00:07:30 UTC

This bug is fixed master. It is going to be backported to KDE 4.6. Fixed by revisions:

fddd1c4378721c0f6d9c758d6923fa2acca113b4 (kdelibs)
0e65a4c2f6dde7f1dd5e4e3b568f62d2e6eaa7b5 (kdelibs)
50328345ddf12893c42872b782b948c68dd07e44 (kdelibs)

3158f651609bf1ca1b874badfeb9dde9d3e9874e (kde-workspace)
340ead143a1c36d4f6731f273eeaf6ddb45fa445 (kde-workspace)

Comment 5 Rafael Fernández López 2011-04-24 00:26:17 UTC

Git commit bea45a78c40368a333197d13e443671c23e45505 by Rafael Fernández López.
Committed on 23/04/2011 at 20:40.
Pushed by ereslibre into branch 'KDE/4.6'.

Take into account RightToLeft environments, and adapt two things:
* Visual rect for items, that need to start from the very right and flow to the left.
* Binary search to find items fast. The search needed to be adapted to reflect this new case.

Following changes on drawers that need to be adapted on this kind of environments.

CCBUG: 238508

M  +37   -11   kdeui/itemviews/kcategorizedview.cpp     

http://commits.kde.org/kdelibs/bea45a78c40368a333197d13e443671c23e45505

Comment 6 Zayed Al-Saidi 2011-04-24 06:36:29 UTC

Thank you Rafael for the fix :)