|Summary:||Infinite loop in "Save diff" when compared files are on different drive letters|
|Product:||[Applications] kompare||Reporter:||Krzysztof Nowicki <krissn>|
|Latest Commit:||http://commits.kde.org/kompare/7ca56c747dbb135ad1f632fde3ceaba54cfff3b5||Version Fixed In:||4.10.4|
Description Krzysztof Nowicki 2010-05-20 14:52:33 UTC
Comment 1 Krzysztof Nowicki 2010-05-20 14:59:44 UTC
Created attachment 43745 [details] Proposed patch The patch fixes the problem, although it's not necessarily a clean solution. An ideal fix would involve adding something like KUrl::isTopLevel() and making use of it here.
Comment 2 Kevin Kofler 2010-05-20 19:03:49 UTC
Your diff is reversed, but otherwise looks OK.
Comment 3 Krzysztof Nowicki 2010-05-20 19:29:15 UTC
It was created with the patched Kompare itself :) I've found a similar bug in KDirSelectDialog::Private::slotComboTextChanged(), but there is more mess in there and it's a subject for another PR.
Comment 4 Kevin Kofler 2010-05-20 19:50:34 UTC
> It was created with the patched Kompare itself :) Try File / Swap source and destination. :-) But I guess that's for next time, we can work with the reversed patch just fine (that's what patch has a -R option for).
Comment 5 Patrick Spendrin 2013-05-02 19:54:39 UTC
Git commit fd2d6e32dfa724f0b2fcffe4766d2d7faf84d437 by Patrick Spendrin. Committed on 02/05/2013 at 13:34. Pushed by sengels into branch 'kde-4.10'. fix endless loop patch taken from bugreport and will be committed asap. M +1 -0 portage/kde/kdesdk/kompare/kompare-20130225.py A +19 -0 portage/kde/kdesdk/kompare/kompare-4.10.2-20130502.diff http://commits.kde.org/emerge/fd2d6e32dfa724f0b2fcffe4766d2d7faf84d437
Comment 6 Patrick Spendrin 2013-05-10 20:54:52 UTC
Git commit d05571620258b9714cbc338c5af6f4419cf601c3 by Patrick Spendrin. Committed on 10/05/2013 at 22:53. Pushed by sengels into branch 'KDE/4.10'. fix endless loop do not go into infinite loop in "save diff" M +2 -2 komparepart/komparesaveoptionswidget.cpp http://commits.kde.org/kompare/d05571620258b9714cbc338c5af6f4419cf601c3
Comment 7 Patrick Spendrin 2013-05-10 20:58:56 UTC
Git commit 7ca56c747dbb135ad1f632fde3ceaba54cfff3b5 by Patrick Spendrin. Committed on 10/05/2013 at 22:53. Pushed by sengels into branch 'master'. fix endless loop do not go into infinite loop in "save diff" M +2 -2 komparepart/komparesaveoptionswidget.cpp http://commits.kde.org/kompare/7ca56c747dbb135ad1f632fde3ceaba54cfff3b5