Summary: | Digikam crashed after moving two albums to the same destination album | ||
---|---|---|---|
Product: | [Applications] digikam | Reporter: | Raphael Ackermann <raphael.ackermann> |
Component: | Database-Albums | Assignee: | Digikam Developers <digikam-bugs-null> |
Status: | RESOLVED FIXED | ||
Severity: | crash | CC: | caulier.gilles |
Priority: | NOR | ||
Version: | 1.2.0 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 1.3.0 | |
Sentry Crash Report: |
Description
Raphael Ackermann
2010-05-14 00:04:40 UTC
Is this reproducable? Any chance album2 was a subalbum of album1, so that while album1 was moved, at any point album2 would be moved as well? There is a null pointer check missing, easy enough to fix, but I dont know why album2 got null while being dragged. I haven't tried to reproduce it. album2 wasn't a subalbum of album1 so no that wasn't the cause. SVN commit 1126674 by mwiesweg: Check if dropped album (still) exists CCBUG: 237555 M +5 -0 albumdragdrop.cpp --- trunk/extragear/graphics/digikam/digikam/albumdragdrop.cpp #1126673:1126674 @@ -62,6 +62,9 @@ PAlbum *destAlbum = model()->albumForIndex(droppedOn); + if (!destAlbum) + return false; + if (DAlbumDrag::canDecode(e->mimeData())) { KUrl::List urls; @@ -70,6 +73,8 @@ return false; PAlbum *droppedAlbum = AlbumManager::instance()->findPAlbum(albumId); + if (!droppedAlbum) + return false; // TODO Copy? KMenu popMenu(view); Crash should be fixed. Reopen if problems persist. |