Bug 236737

Summary: Flickering for seconds/Endless loop when viewing encrypted complex message
Product: [Applications] kdepim Reporter: Thomas McGuire <mcguire>
Component: messageviewerAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: amantia, lfranchi
Priority: NOR Keywords: akonadi-ports-regression
Version: unspecified   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Bug Depends on:    
Bug Blocks: 223438    

Description Thomas McGuire 2010-05-07 19:29:21 UTC 
0. Have fancy header style enabled
1. Create a simple message with an attachment, save as draft
2. Forward that message as attachment, save the result as draft
3. Again Forward that message as attachment, enable encryption (and make sure 
   "never encrypt/sign drafts" option is disabled), save as draft
4. View the message in the viewer and decrypt it. Result: The viewer gets into 
   an endless updating loop. My guess is that the mementos of the temp nodes 
   get deleted at some point (or the temp nodes themselves?). (The header 
   formatter of the encapsulated message tries to create a memento and attach 
   it to the current node (the encapsulated message)
Comment 1 András Manţia 2010-05-20 13:04:11 UTC 
Works for me in trunk.
Comment 2 Thomas McGuire 2010-05-27 19:35:57 UTC 
I can still reproduce it. I think it is related to the contact photos displayed in the fancy header style, which are saved as a memento. Probably the mementos are not associated with the nodes long enough.

To reproduce, the From addresses of all the mails need to be in the addressbook, and the contact in the address book needs to have a photo.

I guess that complex structures with signatures and encryptions will also have a similar problem, as they also use mementos.
Comment 3 Leo Franchi 2010-06-28 21:13:44 UTC 
I can reproduce as well, with the contact photo.
Comment 4 Leo Franchi 2010-06-28 21:22:03 UTC 
Also, does not require a contact photo here. Even without it, i get into the same infinite loop.
Comment 5 Leo Franchi 2010-06-30 01:00:00 UTC 
SVN commit 1144451 by lfranchi:

Fix endless loop on parsing encrypted messages with embedded messages.

BUG: 236737


 M  +2 -2      headerstyle.cpp  
 M  +45 -0     nodehelper.cpp  
 M  +20 -0     nodehelper.h  
 M  +1 -1      objecttreeparser.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1144451