Bug 236732

Summary: Most attachment actions for encrypted attachments don't work
Product: [Applications] kdepim Reporter: Thomas McGuire <mcguire>
Component: messageviewerAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: amantia
Priority: NOR Keywords: akonadi-ports-regression
Version: unspecified   
Target Milestone: ---   
Platform: Unlisted Binaries   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Bug Depends on:    
Bug Blocks: 223438    

Description Thomas McGuire 2010-05-07 18:54:57 UTC 
1. Create a simple mail with a single attachment, activate encryption, and save 
   it as draft (with the "never encrypt drafts" option disabled).
2. View the message in the viewer and decrypt it.
3. The attachment actions don't seem to work:
a) saving the attachment saves a "msg_asc", and not the decrypted attachment
b) Viewing the attachment says" [KMail: Attachment contains binary data. Trying to show first 0 characters.]". The 0 here indicates something is wrong
c) The attachment properties show "application/octet-stream", which is not the 
   mimetype of the attachment
d) Copying does not seem to do anything
e) Open With seems to work :)
f) Deleting the attachment destroys the MIME structure of the message
Comment 1 Thomas McGuire 2010-05-07 19:03:38 UTC 
The attachment actions can be used from 3 places: The attachment quick list in the header, the attachment link in the body and the mimetree viewer. All of them should be tested.
Comment 2 András Manţia 2010-05-09 16:24:00 UTC 
SVN commit 1124580 by amantia:

Fix naviating in the mime tree when an encapsulated message is shown (bug 236725). Thomas, for me viewing the message worked fine, just double clicking on the top node shown the empty message.

Fix message saving and viewing. Works only from the header links ATM (bug 236732).

BUG: 236725
CCBUG: 236732


 M  +1 -1      nodehelper.cpp  
 M  +5 -1      objecttreeparser.cpp  
 M  +5 -1      viewer_p.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1124580
Comment 3 András Manţia 2010-05-18 16:55:05 UTC 
SVN commit 1128174 by amantia:

Make attachment actions work in the mail body as well. Simplify code, remove one method and integrate with another one. Everything works but delete now.
CCBUG: 236732


 M  +1 -1      nodehelper.cpp  
 M  +1 -1      objecttreeparser.cpp  
 M  +2 -3      urlhandlermanager.cpp  
 M  +19 -24    viewer_p.cpp  
 M  +2 -4      viewer_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1128174
Comment 4 András Manţia 2010-05-19 18:12:59 UTC 
All works in rev 1128555. Deleting encrypted attachment doesn't work, but didn't work either in KMail 1. At least now you get an error dialog stating the obvious.