Bug 236419

Summary:	OTR sends xhtml encoded xmpp messages without otr session
Product:	[Unmaintained] kopete	Reporter:	Clara Gnos <clara.gnos>
Component:	general	Assignee:	Kopete Developers <kopete-bugs-null>
Status:	RESOLVED DUPLICATE
Severity:	normal	CC:	andrius, felix_w, mzanetti, shlomif
Priority:	NOR
Version First Reported In:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:
Sentry Crash Report:

Description Clara Gnos 2010-05-05 12:03:49 UTC

Version:           4.4.3 (using KDE 4.4.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

I use different clients which aren't otr or xhtml-im aware. This means that kopete must not send xhtml encoded messages to these clients. This works perfectly in case the otr plugin is _disabled_.

OTR now defines that all data send over it can be (x)html. The problem is that after I enabled the otr plugin (without using otr at all - standard behaviour is opotunistic) it just sends xhtml even when the capabilities of the other clients doesn't support xhtml-im and doesn't supprt otr at all.

Message to google mail with otr plugin enabled in kopete:
<message type="chat" to="testaccount@googlemail.com" id="239">
<body>&lt;p&gt;asd&lt;/p&gt; 	  				 	 	 	   	 	  	   		  	 </body>
<x xmlns="jabber:x:event">
<offline/>
<composing/>
<delivered/>
<displayed/>
</x>
<active xmlns="http://jabber.org/protocol/chatstates"/>
</message>

message to google mail with otr plugin disabled in kopete:
<message type="chat" to="testaccount@googlemail.com" id="241">
<body>asd</body>
<x xmlns="jabber:x:event">
<offline/>
<composing/>
<delivered/>
<displayed/>
</x>
<active xmlns="http://jabber.org/protocol/chatstates"/>
</message>

This bug is not about problems with miranda's otr plugin because it has more faults than features. It was tested using minimal client implementation and actual user clients like the jabber integration in google mail. All output was checked using xml console.

Comment 1 Felix W 2010-05-09 15:14:22 UTC

I can confirm this bug for Kopete 4.4.3 / KDE 4.4.3 running on Arch Linux (tested on both x86 and x86_64 with default Arch KDE as well as KDEmod packages)
For me, only the first messages I send (one or two, didn't test it) after opening a new chat are in (X)HTML. It seems that the protocol doesn't matter. I first noticed this problem when sending a message over ICQ after upgrading my KDE packages.
The problem can be "solved" by downgrading to Kopete 4.4.2 or disabling the OTR plugin.

Comment 2 Shlomi Fish 2010-05-12 21:36:17 UTC

I can confirm this here on Mandriva Linux Cooker ( kopete-4.4.3-3mdv2010.1 ). It annoyed the hell out of my conversation partners.

Comment 3 Andrius Štikonas 2010-05-17 02:36:38 UTC

This is caused by http://websvn.kde.org/?view=revision&revision=1117354

CC: michael_zanetti@gmx.net

Comment 4 Michael Zanetti 2010-05-17 08:25:55 UTC

Duplicate of bug 233330. Patch is on its way...

*** This bug has been marked as a duplicate of bug 233330 ***