Bug 235545

Summary:	Timer for snapshot placed badly
Product:	[Unmaintained] ksnapshot	Reporter:	Fri13 <friiduh>
Component:	general	Assignee:	Richard Moore <rich>
Status:	RESOLVED FIXED
Severity:	wishlist
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:
Attachments:	Fix for bug Id 235545. ame fix as above for 235545 with removed hard coded values.

Description Fri13 2010-04-27 14:55:18 UTC

Version:           0.8.1 (using 4.4.2 (KDE 4.4.2), Mandriva Linux release 2010.1 (Cooker) for x86_64)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.33.2-desktop-3mnb

When user want to take a timed (fullscreen) screenshot, the KSnapshot shows a tooltip on top left corner about timer. This disabled possibility to use the KWin effects activated from desktop corners.

To fix this, the timer should be placed somewhere else than desktop edges/corners. Maybe to center of screen and with nicer way than just the tooltip looking message. Great fix could be making it to be using a plasma and the box could be dragged to wanted place (or kept in center) like the cashew can be already.

Comment 1 jignesh kakadiya 2011-09-26 06:51:17 UTC

Created attachment 63961 [details]
Fix for bug Id 235545.

Changes :
-Overridden moveMouseEvent(*Event);
-Created 3 new globals.To check if timer is on right or left and one for blinking effect.
-Made textRect to global to access it inside the moveMouseEvent();

Can any one check this out? If it is working proper or not.
Thanks.

Comment 2 jignesh kakadiya 2011-09-26 16:58:56 UTC

Created attachment 63988 [details]
ame fix as above for 235545 with removed hard coded values.

Changes:

- Removed two extra globals variables onLeftCorner,onRightCorner.

Hope this will get accepted.My first bug fix:)

Comment 3 Aaron J. Seigo 2011-09-26 18:08:07 UTC

Git commit c20da5231f56ea7275dc4e581bf246a145a16418 by Aaron Seigo.
Committed on 26/09/2011 at 20:07.
Pushed by aseigo into branch 'master'.

move the timeout helper when the mouse moves into it

also moves the initial position of the timer into the middle of the screen and properly centers the text

based on a patch by Jignesh Kakadiya

BUG:235545

M  +34   -12   snapshottimer.cpp
M  +4    -1    snapshottimer.h

http://commits.kde.org/ksnapshot/c20da5231f56ea7275dc4e581bf246a145a16418