Bug 235452

Summary: JJ: KMail should auto-select the address book if there is only one
Product: [Applications] kmail Reporter: Malte S. Stretz <mss>
Component: generalAssignee: kdepim bugs <kdepim-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: goocreations, kde
Priority: NOR Keywords: junior-jobs
Version: 1.13.2   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: Preliminary solution for adding an address automatically to the address book.
Patch

Description Malte S. Stretz 2010-04-26 16:49:44 UTC 
Version:           1.13.2 (using 4.4.2 (KDE 4.4.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.32-21-generic

If you've got only one address book and use the Add to Address Book feature from KMail, it always asks you which address book it should add the address too.  Even if there is only one.  Either that one should be chosen automatically or at least the default address book should be preselected so I can just hit return and everything is fine.
Comment 1 Thomas McGuire 2010-04-29 19:18:22 UTC 
The code is in libkdepim/addemailaddressjob.cpp, I think this makes a nice junior job.
Nicolas, talk to me on IRC about it :)
Comment 2 Nicolas L. 2010-04-29 20:06:22 UTC 
i take this one.

thanks
Comment 3 Nicolas L. 2010-04-30 12:17:01 UTC 
i am quite done with this one.
I have found an other issue that i want to fix on the same time ( when there is no addressbook, you obtain an empty list )
Comment 4 Christoph Stallmann 2010-05-12 13:44:25 UTC 
I know this job has been sort-of assigned to Nicolas, but the status is still on NEW.
I would really like to contribute to KDE, and since I haven't done any bug-fixing in KDE, I would like to be assigned to this job (even if it is already fixed).
This is a small any easy job, so I can get a feeling of how things are done around here.
Comment 5 Christoph Stallmann 2010-06-30 17:49:11 UTC 
Created attachment 48488 [details]
Preliminary solution for adding an address automatically to the address book.

Here is a preliminary solution for this problem, will try to improve it before posting a final solution.
Comment 6 Christoph Stallmann 2010-07-23 19:30:39 UTC 
Created attachment 49442 [details]
Patch
Comment 7 Christoph Stallmann 2010-07-23 19:31:16 UTC 
The final patch was attached
Comment 8 Nicolas L. 2010-08-28 18:05:14 UTC 
SVN commit 1169188 by nlecureuil:

Auto-select the Address Book if there is only one.
Do not show an empty list if there is no Adress Book but warn the user instead.
BUG: 235452



 M  +54 -8     addemailaddressjob.cpp  
 M  +1 -0      addemailaddressjob.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1169188