Bug 234854

Summary: “do you really want to delete this playlist” should include the playlist name
Product: [Applications] amarok Reporter: Arne Babenhauserheide <arne_bab>
Component: Playlists/Saved PlaylistsAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: wishlist CC: bart.cerneels
Priority: NOR    
Version First Reported In: 2.3.0   
Target Milestone: 2.4.0   
Platform: unspecified   
OS: Linux   
Latest Commit: https://invent.kde.org/multimedia/amarok/-/commit/8072bc79aa6a6e448156671de46b07d65e53a7f1 Version Fixed/Implemented In:
Sentry Crash Report:

Description Arne Babenhauserheide 2010-04-20 04:16:32 UTC 
Version:           2.3.0 (using 4.4.2 (KDE 4.4.2), Gentoo)
Compiler:          x86_64-pc-linux-gnu-gcc
OS:                Linux (x86_64) release 2.6.31-gentoo-r6

Otherwise it’s too easy to get the wrong one (better safe than sorry — I just ran into that, losing one of my playlists).
Comment 1 Sven Krohlas 2010-04-20 23:25:23 UTC 
Could you please give us steps to reproduce?
Comment 2 Arne Babenhauserheide 2010-04-21 13:10:13 UTC 
Yes, sorry. 

Go to saved playlists. Select one of the lists and hit the delete key. A dialog appears which asks if I want to delete ‘this’ playlist. 

Getting the wrong list doesn’t show up in the dialog, and I was just a little bit too careless.
Comment 3 Bart Cerneels 2010-04-29 10:43:32 UTC 
That is a good suggestion.
This will have to wait until string freeze is lifted.
Comment 4 Arne Babenhauserheide 2010-04-29 12:38:17 UTC 
many thanks!
Comment 5 Kevin Funk 2010-07-08 16:55:18 UTC 
I do not think this is necessary as you still got the visual indicator on which line is selected in the list view.

But just found a bug: Pressing Del just deletes the item, and then asks for confirmation...
Comment 6 Arne Babenhauserheide 2010-07-09 09:38:58 UTC 
Point is: It’s very easy to miss the selected line being one line too far down (I don’t doublecheck that after selection – after all I clicked there). Having the additional information in the warning should make accidental deletion much less likely. 

But firstoff: Thanks for fixing the “deletion before notificaton” bug!
Comment 7 Kevin Funk 2010-07-09 11:26:30 UTC 
It's not yet fixed yet. But I created another bug report as I am not familiar with that code. See bug 243966
Comment 8 Bug Janitor Service 2024-05-04 07:47:20 UTC 
A possibly relevant merge request was started @ https://invent.kde.org/multimedia/amarok/-/merge_requests/93
Comment 9 Tuomas Nurmi 2024-05-04 17:25:59 UTC 
Git commit 8072bc79aa6a6e448156671de46b07d65e53a7f1 by Tuomas Nurmi.
Committed on 04/05/2024 at 07:41.
Pushed by nurmi into branch 'master'.

Show name or count of playlists in deletion confirmation dialog

M  +1    -1    ChangeLog
M  +7    -2    src/browsers/playlistbrowser/PlaylistBrowserView.cpp

https://invent.kde.org/multimedia/amarok/-/commit/8072bc79aa6a6e448156671de46b07d65e53a7f1