Bug 234845

Summary:	Bad Account after importing ofx
Product:	[Applications] skrooge	Reporter:	Guillaume Stamm <guillaume.stamm>
Component:	general	Assignee:	Stephane MANKOWSKI <stephane>
Status:	RESOLVED FIXED
Severity:	normal	CC:	guillaume.stamm, stephane
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Ubuntu
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	screen shot of the problem

Description Guillaume Stamm 2010-04-20 00:01:55 UTC

Version:           0.7.1 (svn version 20100419) (using KDE 4.4.2)
OS:                Linux
Installed from:    Ubuntu Packages

I'm testing the correction : [Bug 234771] Problem importing ofx (quicken) file
and found something new; take a look at the attached image;
the imported operations are going into a new account with bad Agency Number and bad Number.
(for testing you can use the same file as Bug 234771)

the ofx fields :
<BANKID>18206       => OK correctly imported
<BRANCHID>00172     => KO imported in account number 
<ACCTID>43980062001 => KO not imported

Comment 1 Guillaume Stamm 2010-04-20 00:03:38 UTC

Created attachment 42907 [details]
screen shot of the problem

a new account is created during import => bad   (red bubbles)

Comment 2 Stephane MANKOWSKI 2010-04-20 21:28:51 UTC

SVN commit 1116982 by smankowski:

BUG: 234845: Bad Account after importing ofx

 M  +1 -1      skgimportexportmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1116982

Comment 3 Stephane MANKOWSKI 2010-04-20 21:34:32 UTC

Hi,

To be clear, the correction has been done partially because a problem exist in libofx.

Description of this issue if you want to open an incident on libofx:
In you file, you have:
<BANKACCTFROM>
<BANKID>18206
<BRANCHID>00172
<ACCTID>43980062001
<ACCTKEY>78
<ACCTTYPE2>CHECKING
</BANKACCTFROM>

with this, the import is done like this because information are returned like this by libofx:
Bank number=18206     ==>OK
Agency number=00172   ==>OK
Number=00172          ==>KO

If you remove <ACCTKEY>78 from your file the import will be done like this:
Bank number=18206     ==>OK
Agency number=00172   ==>OK
Number=43980062001    ==>OK

Conclusion: The ofx behavior change if <ACCTKEY> is in the file !

Comment 4 Guillaume Stamm 2010-04-24 23:49:40 UTC

From: Benoit Grégoire <benoitg@coeus.ca>
Date: 2010/4/24
Subject: Re: LibOfx problème: Fwd: [Bug 234845] Bad Account after importing ofx
To: Guillaume Stamm <guillaume.stamm@gmail.com>

Le problème est dans le fichier d'origine, il ne valide pas le schéma.
<ACCTTYPE2> et <ACCTKEY> sont inversés.  Comme le format OFX est basé sur
SGML, le parsing est entièrement dépendant du schéma (les tags n'étant pas
fermés).