Bug 234571

Summary:	Current actions not reset to default immediately in Configure Toolbars
Product:	[Applications] korganizer	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	David Faure <faure>
Status:	RESOLVED FIXED
Severity:	normal	CC:	faure, smartins
Priority:	LO
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:	4.6
Sentry Crash Report:

Description Sabine Faure 2010-04-16 23:53:47 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Go to Settings menu/Configure Toolbars...
- Add three available actions (ex: copy, paste, delete) to the current actions.
- Click on 'Apply' and the actions should be added as buttons in KOrg main toolbar.
- Now click on 'Defaults' button
- A 'Do you really want to reset all toolbars of this application to their default? The changes will be applied immediately' message appears in a pop up dialogue.
- Click on 'Reset'

The added buttons are correctly removed from the toolbar in KOrg main window but they are still displayed in the current actions table.

However it seems to be an update pb since when closing the dialogue and reopening it the actions are back in the available actions column where they should be.

Trunk, Svn Rev 1115397

Comment 1 Sabine Faure 2010-04-17 02:15:40 UTC

The same bug happens with all the toolbars (main, views, schedule, Filters) from this dialogue.

Trunk, Svn Rev 1115397

Comment 2 Sergio Martins 2010-09-07 11:17:50 UTC

Can you test with another KDE app and re-assign this bug if you reproduce?

Comment 3 David Faure 2010-11-19 02:30:04 UTC

SVN commit 1198579 by dfaure:

* Fix toolbar editing when using setLocalXMLFile: the setXMLFile(ui_standards.rc) would find the localxmlfile instead,
and one would end up with "No text!" menus, ouch. Or something else went wrong and one would end up with tons of empty menus.
I added a new method loadStandardsXmlFile() which loads ui_standards.rc without unwanted side effects, much cleaner.

* slotDefault: reload the XML before reloading the action list widgets, otherwise they are still outdated
BUG: 234571
FIXED-IN: 4.6


 M  +12 -12    dialogs/kedittoolbar.cpp  
 M  +16 -3     xmlgui/kxmlguiclient.cpp  
 M  +9 -0      xmlgui/kxmlguiclient.h  
 M  +1 -1      xmlgui/kxmlguiwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1198579

Comment 4 David Faure 2010-11-19 02:39:18 UTC

*** Bug 209162 has been marked as a duplicate of this bug. ***