| Summary: | device manager popup in the middle of a screen | ||
|---|---|---|---|
| Product: | [Unmaintained] plasma4 | Reporter: | Alex <PhilatAlexander> |
| Component: | widget-devicenotifier | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | RESOLVED UNMAINTAINED | ||
| Severity: | normal | CC: | afiestas, aseigo, benderamp, bigbrovar, darkvision, denis, desintegr, dmitry, Freiheits, gstengel, KaiUweBroulik2, kde, kde, lamarque, leszek.lesner, mani5984, n.schnelle, notmart, oliver.henshaw, ozan, phoenix_firebrd, pw1517, sordon, travneff, wilderkde |
| Priority: | NOR | ||
| Version: | 4.9.0 | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Bug
Popup position after the latest fixes Fig 1 Fig 2 battery applet plasmoid regression????? The snapshot shows the device notifier panel is show in a wrong place instead of sticking to the system tray |
||
|
Description
Alex
2010-04-16 21:22:53 UTC
Version: KDE 4.4.3 OS: Linux Installed from: Debian Sid I have the same effect. The device manager is activated as part of the system tray. The first time I plug in an USB stick the device manager popup appears on the left side in the middle of the screen. After this initial popup all other popups are right above the system tray as it should be. This bug is also present in Kubuntu Lucid, KDE 4.4.5 Also present in Debian Squeeze with KDE 4.4.5 . It wasn't there with KDE 4.4.4 though. I can reproduce the problem with 4.4.x but not with the 4.5 series? Can you confirm the issue is gone with 4.5? It's present on KDE 4.6.1 (openSUSE packages from build service, using OS 11.4). The official OS 11.4 packages (using KDE 4.6.0) don't seem to have the problem, though, maybe it's patched there). Would be nice to fix this upstream, it's been there for quite some time... (In reply to comment #5) > It's present on KDE 4.6.1 (openSUSE packages from build service, using OS > 11.4). The official OS 11.4 packages (using KDE 4.6.0) don't seem to have the > problem, though, maybe it's patched there). Would be nice to fix this upstream, > it's been there for quite some time... OpenSUSE patches for 4.6.0 and 4.6.1 are same and there are no commits in devisenotifer applet from august 2010. So i think its tray bug because devisenotifer appears in the place, there will be top of pop-up list of hidden icons. And if you show always for devisenotifer icon applet will appear in right place. Yes, true, I can confirm this. If I permanently show the device notifier in the tray the popup comes up at the correct place. This may be good enough as a workaround. I think this bug report should be assigned to the system tray people, shouldn't it? *** Bug 270249 has been marked as a duplicate of this bug. *** *** Bug 267795 has been marked as a duplicate of this bug. *** Created attachment 58679 [details]
Bug
I can confirm this bug. See screenshot. Bug still present in 4.6.2 :( *** This bug has been confirmed by popular vote. *** This only happens if the device notifier is enabled in the systemtray. Add aseigo to CC. Git commit bb5e7a3d6e32d5435bfba79a03614396e17c3650 by Marco Martin. Committed on 20/04/2011 at 18:07. Pushed by mart into branch 'master'. popup in the correct place when viewFor is hidden when item is in an hidden Dialog, try to find the parent applet and position the popup there. this fixes the devicenotifier popup placement BUG:253858 BUG:234564 M +32 -12 plasma/corona.cpp http://commits.kde.org/kdelibs/bb5e7a3d6e32d5435bfba79a03614396e17c3650 Git commit cfe34fcf05d0c007a8d2d7087bf368d46cd31a03 by Marco Martin. Committed on 20/04/2011 at 18:10. Pushed by mart into branch 'master'. fix popup position if item is in an hidden Dialog, try to find the parent applet and use it instead of item this fixes the device notifier popup placement BUG:234564 BUG:253858 M +4 -0 plasma/corona.cpp http://commits.kde.org/kdelibs/cfe34fcf05d0c007a8d2d7087bf368d46cd31a03 I think the backport to the 4.6 branch is missing the s/item/actualItem changes that you've actually did in the master branch. But even if I take that hunks too, I got a consistent segfault during startup. @notmart: could you please have a look at the last comment? thankx @notmart: could you please have a look at the last comment? thankx @notmart: could you please have a look at the last comment? thankx uhm, there should be a single commit with everything.. I can confirm that the commit as a diff fails at two locations, and that, when manually applying, plasma segfaults on each start. However, I just applied the patch and I did not get the whole kdelibs out of git. Might be related, might not be related. Unfortunately I don't have access to my test machine for the week-end (Easter), so I can't give a backtrace right now. I will try to create one next week and send it, if still necessary. Thanks in advance for looking into this, happy Easter, Christian I also backported two commits mentioned from trunk, it still segfaults at: pos = v->mapFromScene(actualItem->scenePos()); In the backtrace it says: mapFromScene(this=0x0) Maybe v is NULL, I don't know. I did this small patch which fixed the issue.
Can i commit this on git ?
diff --git a/plasma/corona.cpp b/plasma/corona.cpp
index c6fedb1..7df6680 100644
--- a/plasma/corona.cpp
+++ b/plasma/corona.cpp
@@ -784,6 +784,11 @@ QPoint Corona::popupPosition(const QGraphicsItem *item, const QSize &s, Qt::Alig
}
}
+
+ if (!v) {
+ return QPoint(0, 0);
+ }
+
//if the applet is rotated the popup position has to be un-transformed
if (sceneTransform.isRotating()) {
qreal angle = acos(sceneTransform.m11());
Git commit 36a8e02457e554db188d0d83e8ad24cfc9a0dc86 by Nicolas Lécureuil. Committed on 22/04/2011 at 10:50. Pushed by nlecureuil into branch 'KDE/4.6'. Fix crash CCBUG:234564 M +5 -0 plasma/corona.cpp http://commits.kde.org/kdelibs/36a8e02457e554db188d0d83e8ad24cfc9a0dc86 Created attachment 59293 [details]
Popup position after the latest fixes
Ok the commit fixes the crash problem and device notifier popup doesn't appear in the middle of a screen but it still appears wrongly, at the opposite horizontal side of the screen.
I can fully confirm the above comment (archlinux kde 4.6.3) Confirmed, the bug is now different (Popup appears on the opposite side of the screen, left instead of right) but still present in 4.6.3. This annoying bug was introduced in 4.6.1 and is still present 2 months later. It would be great if there was a fix for it. Thanks in advance for fixing it, kind regards Christian I can not confirm it. opensuse 11.3 KDE 4.6.3 from this repo http://download.opensuse.org/repositories/KDE:/Release:/46/openSUSE_11.3/ When you first install any YUSB drive, Device Manager window opens in the left side of the screen away from the system tray icon. (Figure 1) If you expand the window by clicking the system tray icon then a window set in the right of the screen as needed. (Figure 2) I think that in the first case the window must be deployed on the right side of the screen Created attachment 59772 [details]
Fig 1
Created attachment 59773 [details]
Fig 2
Please reopen the bug Trouble with battery applet plasmoid Created attachment 59812 [details]
battery applet plasmoid
*** Bug 273062 has been marked as a duplicate of this bug. *** Created attachment 60188 [details]
regression?????
I can confirm same problem for Notifications popup - when I copy/save some file with progress, the final message "copy finished" appears on the center of the screen. I have almost just updated to 4.6.3 from opensuse repo and this started to happen all the time, I was using 4.6.2 for some time before that and don't remember this problem. Device notifier plasmoid is ok (it is added directly to the panel, not to systray though). I can experience the thing Igor Strelnikoff has posted, the device notifier pops up on the left of the screen rather than above the system tray where the notifier is. I think this is due to the auto hide option being enabled. Same here on Slackware 13.37 with KDE 4.6.3/devicenotifier. PopUps from other applications do also show up in the middle of the screen. The same PopUps appeared on the lower right corner of the screen when using KDE 4.5.5. It works as expected in KDE 4.7 4.7.0, the issue is still here. Never saw this issue in 4.6.2 or earlier, in 4.6.3 and 4.6.4 notifications started to popup in the middle of the screen, now in 4.7.0 notifications are shown on the bottom left corner above the panel, but tray icon is located on the right side of the panel. This is only about notification popups, other plasmoid popups (including device notifier and network manager) are shown on their right places. I can confirm the same behavior under KDE 4.6.5 as comment #41. *** Bug 276730 has been marked as a duplicate of this bug. *** so this is a number of different bugs rolled into one; the notification popups issue has been resolved (that code was actually reworked for 4.8 to address positioning issues) and the other plasmoids affected appear to have been fixed by the previous fixes. if this problem persists for specific plasmoids in 4.8, please open new reports, one for each plasmoid affected, along with screenshots if possible (much easier to diagnose than trying to recreate the scene from a textual description :) thanks .. This bug still appears in kde 4.9.0. Using Kubuntu 12.10. Created attachment 73649 [details]
The snapshot shows the device notifier panel is show in a wrong place instead of sticking to the system tray
The snapshot shows the device notifier panel is show in a wrong place instead of sticking to the system tray
(In reply to comment #46) > Created attachment 73649 [details] > The snapshot shows the device notifier panel is show in a wrong place > instead of sticking to the system tray > > The snapshot shows the device notifier panel is show in a wrong place > instead of sticking to the system tray Adding to that the information Prasad gave me on IRC: Kubuntu Quantal 12.10 of today, KDE 4.9.0. @notmart: I can still reproduce with current master :( Anyone can reproduce it? I have not notice that bug for a long time... (In reply to Denis Pesotsky from comment #49) > Anyone can reproduce it? > > I have not notice that bug for a long time... I'm having the same issue on KDE 5.2. It goes away when I restart my KDE session, but it comes back sporadically. It also happens to all of the plasmoids with popups (klipper, battery, notifications, calendar, etc.) Here is how it currently looks on my system. https://i.imgur.com/Qtpdw1z.png Hello! This bug report was filed for KDE Plasma 4, which reached end-of-support status in August 2015. KDE Plasma 5's desktop shell has been almost completely rewritten for better performance and usability, so it is likely that this bug has already been resolved in Plasma 5. Accordingly, we hope you understand why we must close this bug report. If the issue described here is still present in KDE Plasma 5.12 or later, please feel free to open a new ticket in the "plasmashell" product after reading https://community.kde.org/Get_Involved/Bug_Reporting If you would like to get involved in KDE's bug triaging effort so that future mass bug closes like this are less likely, please read https://community.kde.org/Get_Involved#Bug_Triaging Thanks for your understanding! Nate Graham |
