| Summary: | 2 duplicated options in configuration dialogue | ||
|---|---|---|---|
| Product: | [Unmaintained] klipper | Reporter: | Jonathan Marten <jjm> |
| Component: | general | Assignee: | Esben Mose Hansen <kde> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | dimsuz, lueck |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Compiled Sources | ||
| OS: | Unspecified | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: |
Patch to fix duplicated options
remaing string changes from Jonathan's pach in comment #1 |
||
|
Description
Jonathan Marten
2010-04-14 16:25:40 UTC
Created attachment 42778 [details]
Patch to fix duplicated options
Also cleans up some other visible strings:
abbreviated "Config" -> "Configuration",
consistent case in "Ignore selection" option,
paragraph break in 3 long tooltips,
add "..." to "Advanced" button.
ping ... as we are at it, the "ignore images" and "text selection only" options seem to have some overlap, and i don't see why the latter is selection-specific. the wording of both is suboptimal. thanks for the ping, I seems to have missed this patch. sorry, I will look into it when baby-free. text selection is different from avoid images in that usually, you don't want to copy images on selection. I'd agree that this needs work when we support more types than urlbundles, images and text. Git commit 3a84c292a906e2225dc6ac51933255920d059d62 by Burkhard Lück. Committed on 31/07/2011 at 19:24. Pushed by lueck into branch 'KDE/4.7'. Delete duplicated configuration options Klipper's configuration dialog has duplicated options kcfg_ReplayActionInHistory + kcfg_StripWhiteSpace on the General + Actions page. Commit log of Revision 1052730 (added kcfg_ReplayActionInHistory + kcfg_StripWhiteSpace to actionsconfig.ui) reads: 'Move actions-related config to action config dialog...' Apparently it was forgotten to delete these actions from generalconfig.ui, so in fact it was a Copy not a Move. REVIEW:102150 CCBUG:234355 (cherry picked from commit 3326a0f1c58809176020be54aa17d52ca94878ef) M +0 -14 klipper/generalconfig.ui http://commits.kde.org/kde-workspace/3a84c292a906e2225dc6ac51933255920d059d62 Git commit 3326a0f1c58809176020be54aa17d52ca94878ef by Burkhard Lück. Committed on 31/07/2011 at 19:24. Pushed by lueck into branch 'master'. Delete duplicated configuration options Klipper's configuration dialog has duplicated options kcfg_ReplayActionInHistory + kcfg_StripWhiteSpace on the General + Actions page. Commit log of Revision 1052730 (added kcfg_ReplayActionInHistory + kcfg_StripWhiteSpace to actionsconfig.ui) reads: 'Move actions-related config to action config dialog...' Apparently it was forgotten to delete these actions from generalconfig.ui, so in fact it was a Copy not a Move. REVIEW:102150 CCBUG:234355 M +0 -14 klipper/generalconfig.ui http://commits.kde.org/kde-workspace/3326a0f1c58809176020be54aa17d52ca94878ef Created attachment 62391 [details] remaing string changes from Jonathan's pach in comment #1 @Jonathan: These are the remaining string changes from your patch, which completely makes sense to. @esben: Objections to commit this to master? (4.7 is in string freeze) (In reply to comment #6) > Created an attachment (id=62391) [details] > remaing string changes from Jonathan's pach in comment #1 > > @Jonathan: > These are the remaining string changes from your patch, which completely makes > sense to. > > @esben: > Objections to commit this to master? (4.7 is in string freeze) Ping? Looks good to me. Git commit 20eecd3fb223fc68c48fe527d6192ae9f55a11a6 by Burkhard Lück. Committed on 12/08/2011 at 22:21. Pushed by lueck into branch 'master'. fix wording, based on a patch by Jonathan Marten and ack'ed by Esben Mose Hansen BUG:234355 M +3 -3 klipper/configdialog.cpp M +1 -1 klipper/actionsconfig.ui M +3 -3 klipper/klipper.kcfg http://commits.kde.org/kde-workspace/20eecd3fb223fc68c48fe527d6192ae9f55a11a6 |