Bug 234332

Summary:	Images on Random and Loop Buttons are switched
Product:	[Unmaintained] kscd	Reporter:	Eric Zayas <eric.zayas>
Component:	general	Assignee:	Aaron J. Seigo <aseigo>
Status:	RESOLVED FIXED
Severity:	normal	CC:	avbidder+kde, d_k, egdfree, eric.zayas, rdieter, zilla
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Linux
Latest Commit:	http://commits.kde.org/kscd/b9dc815280b4144564745b0b68dc581a04ceb58a	Version Fixed In:	4.12.5
Sentry Crash Report:
Attachments:	loop-random button patch

Description Eric Zayas 2010-04-14 12:45:22 UTC

Version:           4.4 (using KDE 4.4.0)
OS:                Linux
Installed from:    openSUSE RPMs

The startup images for the loop and Random buttons are switched.  The Random button shows a loop image and the Loop button shows the random image.

Comment 1 Christoph Feck 2010-07-01 01:08:31 UTC

*** Bug 241652 has been marked as a duplicate of this bug. ***

Comment 2 Dave Kaye 2011-08-17 14:47:21 UTC

Created attachment 62902 [details]
loop-random button patch

The loop and random button images are switched from conventional usage.  The arrows completing a circle or a square are commonly used by other programs to indicate a loop while arrows diverging out indicate random (see VLC and others).

The attached patch will switch the button images.  It was created by using a text editor on the xml image files.  No software code was modified.  The pictures were not modified in any way, only the names (id tags) were switched.

Comment 3 EGD 2013-04-19 16:12:48 UTC

I reproduce this bug for KDE: 4.10.2 "release 556" KsCD: 1.5.

Comment 4 Christoph Feck 2014-04-18 02:29:15 UTC

*** Bug 333499 has been marked as a duplicate of this bug. ***

Comment 5 Jonathan Wakely 2014-04-18 09:18:45 UTC

There's been a patch for two and a half years, and I've also attached a patch to Bug 333499 (apologies for the dup, the search wasn't working the other day), could someone please fix it, so users stop wasting their time patching the same thing?

Also, you've closed my CONFIRMED bug as a dup of this UNCONFIRMED one, so it's now actually progressed backwards.

Comment 6 Rex Dieter 2014-04-18 12:43:23 UTC

Confirmed (from dup), and all the "me too's"

Comment 7 Rex Dieter 2014-04-18 12:58:21 UTC

Git commit 357eb85684552c237803ffa9db037b3918a7a220 by Rex Dieter.
Committed on 18/04/2014 at 12:48.
Pushed by rdieter into branch 'KDE/4.12'.

Swap names of loop/random buttons
Related: bug 333499
FIXED-IN: 4.12.5

M  +6    -6    gui/skin/Chrome.svg
M  +6    -6    gui/skin/Obsidian-Coast.svg
M  +6    -6    gui/skin/Steel.svg
M  +6    -6    gui/skin/default.svg

http://commits.kde.org/kscd/357eb85684552c237803ffa9db037b3918a7a220

Comment 8 Rex Dieter 2014-04-18 12:58:39 UTC

Git commit 1f2409a6c2a05b8c4d4f3e9e546b8ecd48b5b857 by Rex Dieter.
Committed on 18/04/2014 at 12:48.
Pushed by rdieter into branch 'KDE/4.13'.

Swap names of loop/random buttons
Related: bug 333499
FIXED-IN: 4.12.5

M  +6    -6    gui/skin/Chrome.svg
M  +6    -6    gui/skin/Obsidian-Coast.svg
M  +6    -6    gui/skin/Steel.svg
M  +6    -6    gui/skin/default.svg

http://commits.kde.org/kscd/1f2409a6c2a05b8c4d4f3e9e546b8ecd48b5b857

Comment 9 Rex Dieter 2014-04-18 12:58:54 UTC

Git commit b9dc815280b4144564745b0b68dc581a04ceb58a by Rex Dieter.
Committed on 18/04/2014 at 12:48.
Pushed by rdieter into branch 'master'.

Swap names of loop/random buttons
Related: bug 333499
FIXED-IN: 4.12.5

M  +6    -6    gui/skin/Chrome.svg
M  +6    -6    gui/skin/Obsidian-Coast.svg
M  +6    -6    gui/skin/Steel.svg
M  +6    -6    gui/skin/default.svg

http://commits.kde.org/kscd/b9dc815280b4144564745b0b68dc581a04ceb58a