Bug 234078

Summary: Geolocation tab from right sidebar : hide MapView for image without coordinates
Product: [Applications] digikam Reporter: Philippe ROUBACH <philippe.roubach>
Component: Geolocation-WorkflowAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, mike
Priority: NOR    
Version: 5.0.0   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In: 7.5.0
Sentry Crash Report:
Attachments: digikamgeogrey.png

Description Philippe ROUBACH 2010-04-11 18:55:25 UTC
Version:           1.2.0 (using 4.4.2 (KDE 4.4.2), Mandriva Linux release 2010.1 (Cooker) for i586)
Compiler:          gcc
OS:                Linux (i686) release 2.6.33.2-desktop-1mnb

launch digikam
digikam by default points to the fist photo of the album

if this photo has no geo coordinates
then
gpswidget instead of displaying nothing displays in grey the place of the first photo in the album which has geo coordinates

see the capture
Comment 1 Philippe ROUBACH 2010-04-11 18:56:10 UTC
Created attachment 42691 [details]
digikamgeogrey.png
Comment 2 Michael G. Hansen 2010-04-11 19:01:14 UTC
Hi Philippe,

I think is a duplicate of bug #225827 which you filed a while ago. The problem was fixed by Marcel, and I just checked in trunk, I can not reproduce it.

Michael

*** This bug has been marked as a duplicate of bug 225827 ***
Comment 3 Philippe ROUBACH 2010-04-11 19:57:02 UTC
no it is not the same pb

it is about a photo with no gps ccordinates
in this case you must display nothing in the gpswidget panel

instead of doing this gpswidget displays in grey the place of another photo

what is the another photo ?
the first in the album with gps coordinates
Comment 4 Michael G. Hansen 2010-04-11 20:36:51 UTC
Sorry, I do not quite understand ;-)

So you are saying: The first photo in your album has no GPS coordinates and the gps widget is grey. But it displays another photo instead? Your screenshot does not show this photo, though.

I can not reproduce this here in trunk and I do not have version 1.2 available at the moment.

Maybe somebody else with 1.2 can test it?

Michael
Comment 5 Philippe ROUBACH 2010-04-11 20:47:25 UTC
i explain again

the first photo in the album has no coordinates
then
when you launch digikam
then
digikam selects the first photo of the album

because this photo has no coordinates gpswidget must not display any place
right ?
instead of doing this, gpswidget displays the place of the first photo which has coordinates
Comment 6 Marcel Wiesweg 2010-04-11 20:52:09 UTC
I can confirm this. The GPS widget is disabled, it is greyed out, but that is not a strong change. You can still see the map and the indicated position. And this position is unchanged, because when the newly selected image has no GPS data, the map position is not reset, just the map is disabled, but this is visually not clear. We should hide the map or do something similar.
Comment 7 caulier.gilles 2011-12-13 09:40:07 UTC
Philippe, 

This entry still valid with digiKam 2.x ?

Gilles Caulier
Comment 8 Philippe ROUBACH 2011-12-15 11:37:01 UTC
mandriva 2010.2
digikam 1.9.0

pb still there

sorry i don't have the 2.x version
Comment 9 caulier.gilles 2011-12-15 11:41:01 UTC
update your system with a more recent KDE version, more version marblewidget, and more version of digiKam.

Also, 2.x version using libkgeomap will work better. digiKam 1.x is not maintained anymore...

Gilles Caulier
Comment 10 Michael G. Hansen 2011-12-27 15:34:36 UTC
Still there in current git master.

Michael
Comment 11 Philippe ROUBACH 2014-01-11 12:08:10 UTC
opensuse 13.1 , kde 4.12 , digikam 3.5

still valid
Comment 12 Philippe ROUBACH 2014-08-24 08:21:12 UTC
opensuse 13.1 x86_64
kde 4.13.3
digikam 4.2.0

pb still there
Comment 13 Michael G. Hansen 2014-09-04 09:14:44 UTC
Gilles,

let's keep "geolocation tab" in the title. Just MapView can be easily confused with the map in the center, which can replace the thumbnail view.

Michael
Comment 14 Philippe ROUBACH 2019-02-28 12:56:19 UTC
obsolete i close it
Comment 15 caulier.gilles 2019-02-28 15:58:09 UTC
No, for me this entry still valid, and we must write code to hide map (disabled) in case of no GPS position.

Gilles Caulier
Comment 16 caulier.gilles 2022-01-10 17:21:51 UTC
Git commit df06915e1271554ce499c4dc19d0170377fbd443 by Gilles Caulier.
Committed on 10/01/2022 at 17:14.
Pushed by cgilles into branch 'master'.

center map to 0.0 coordiantes if no GPIS innfo is available
FIXED-IN: 7.5.0

M  +1    -0    core/libs/properties/geolocation/itempropertiesgpstab.cpp

https://invent.kde.org/graphics/digikam/commit/df06915e1271554ce499c4dc19d0170377fbd443
Comment 17 caulier.gilles 2022-01-11 16:57:17 UTC
Git commit 71e8785e751bda6eec08f93f985a2c472324ebaf by Gilles Caulier.
Committed on 11/01/2022 at 16:43.
Pushed by cgilles into branch 'master'.

Best solution to hide geolocation map from Right sidebar if no GPS info is available

M  +26   -12   core/libs/properties/geolocation/itempropertiesgpstab.cpp

https://invent.kde.org/graphics/digikam/commit/71e8785e751bda6eec08f93f985a2c472324ebaf