Bug 233989

Summary:	kmenuedit shortcuts should be enabled by default
Product:	[Applications] systemsettings	Reporter:	RalphB <pub>
Component:	kcm_khotkeys	Assignee:	Michael Jansen <kde>
Status:	RESOLVED FIXED
Severity:	normal	CC:	mss
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description RalphB 2010-04-10 22:28:10 UTC

Version:           1.0 (using 4.4.2 (KDE 4.4.2), Kubuntu packages)
OS:                Linux (x86_64) release 2.6.32-19-generic

Keyboard shortcuts defined by kmenuedit are disabled by default.  This, however, is not apparent within kmenuedit itself.  Instead, kmenuedit shortcuts need to be enabled in System Settings, tab Input Actions.

This is very counter-intuitive and leads people to believe that shortcuts are broken.

Comment 1 Michael Jansen 2010-04-11 01:27:57 UTC

I can't reproduce this problem. Any shortcut i set with kmenuedit immediately works. And that is how it is supposed to be.

This was a problem in some earlier release (i think 4.1). But i can't imagine you use such a old version.

Comment 2 RalphB 2010-04-11 11:17:36 UTC

Just for clarification: The problem is NOT with kmenuedit, but with systemsettings.

On a fresh install (in my case Kubuntu 10.4 Beta 1), navigate to System Setting -> Input Actions.  On the left-hand side there are several categories, including KMenuEdit.  The checkmark next to KMenuEdit was missing, thus disabling all kmenuedit shortcuts.  I suggest to change this default.

(If this is a Kubuntu issue rather than a general KDE issue then please let me know and I'll open a ticket with Ubuntu.)

Comment 3 Michael Jansen 2010-04-12 01:00:22 UTC

SVN commit 1113851 by mjansen:

BUG: 233989

(The new user was the clue)

Fix a implicit conversion from enum to bool combined with a reinterpretation
of the meaning.

 M  +1 -1      kcm_hotkeys/hotkeys_context_menu.cpp  
 M  +1 -1      kcm_hotkeys/hotkeys_model.cpp  
 M  +5 -5      libkhotkeysprivate/settings.cpp  
 M  +1 -1      libkhotkeysprivate/settings.h  
 M  +45 -15    libkhotkeysprivate/settings_reader_v2.cpp  
 M  +5 -3      libkhotkeysprivate/settings_reader_v2.h  
 M  +1 -1      libkhotkeysprivate/settings_writer.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1113851

Comment 4 Malte S. Stretz 2010-05-11 14:29:51 UTC

This still happens on a KDE 4.4.3 which was upgraded from 4.4.2.  Is that caused by old settings lingering around or wasn't this patch backported to the 4.4 branch?