Bug 233950

Summary: some filter preview have glitches
Product: [Applications] krita Reporter: enkithan
Component: FiltersAssignee: Halla Rempt <halla>
Status: RESOLVED DUPLICATE    
Severity: normal CC: cberger, dimula73, halla, lukast.dev
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description enkithan 2010-04-10 15:13:25 UTC 
Version:           2.2 Beta 2 (using 4.4.2 (KDE 4.4.2), Arch Linux)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.33-ARCH

Some filter display a wrong result in their preview. The preview is wrong with at least these filter :
*blur (blurry seams/lines every 512*512 pixels squares)
*small tiles (result is mixed with the filtered layer data, instead of replacing it)
*oilpaint (noise rendering)
*Sobel (the layer becomes completely transparent)

If we apply the filter and close the filter gallery, we see that filter works correctly, so the problem is only in the preview.
Comment 1 Sven Langkamp 2010-04-12 21:12:57 UTC 
The problem appears with all filters that don't support threading when applied by a filter mask.
Comment 2 Dmitry Kazakov 2010-04-12 22:18:24 UTC 
Boud, do we still use some "filter strategy" here or just pass the work to the merger?
Comment 3 Halla Rempt 2010-04-13 09:24:56 UTC 
The preview is just a filter mask node, so nothing special should be happening there.
Comment 4 Halla Rempt 2010-08-11 22:32:35 UTC 
Sobel looks completely broken, also when applied. As for the othe filters, ack.
Comment 5 LukasT 2010-10-21 10:45:40 UTC 
>*blur (blurry seams/lines every 512*512 pixels squares)

This has been fixed. I'm starting to work on this one.
Comment 6 LukasT 2010-10-21 13:25:51 UTC 
SVN commit 1188093 by lukast:

Fixing: result is mixed with the filtered layer data, instead of
replacing it

Copy the result instead of alpha-blending.
The preview is still broken.

CCBUG:233950

 M  +3 -0      kis_small_tiles_filter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1188093
Comment 7 LukasT 2010-11-11 17:49:13 UTC 
I think we should disable Sobel for 2.3 as it works only on RGB8 and magically on RGB16. I think that sobel should be in the standard distribution of Krita. Maybe Matus could work on it. It does not thread colors with pigment but it is direct ugly port from GIMP

Oilpaint is also broken and should be disabled from installation. Maybe work for Matus too :)

Small tiles has broken preview, seems to me that it will require API change in filters.

Blur is working fine now.
Comment 8 Cyrille Berger 2010-12-14 19:08:41 UTC 
SVN commit 1206510 by berger:

disable smalltiles, oilpaint, sobel filters, since they are broken

CCBUG:233950


 M  +2 -2      oilpaintfilter/CMakeLists.txt  
 M  +2 -2      smalltilesfilter/CMakeLists.txt  
 M  +2 -2      sobelfilter/CMakeLists.txt  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1206510
Comment 9 Cyrille Berger 2010-12-14 19:10:42 UTC 
Not a release blocker for 2.3 anymore.
Comment 10 Sven Langkamp 2012-01-20 00:44:42 UTC 

*** This bug has been marked as a duplicate of bug 289191 ***