Summary: | configuration dialogue in Amarok is too wide, can't be shrinked | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | Cyril Brosch <info> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | kretschmann |
Priority: | NOR | ||
Version: | 2.3.0 | ||
Target Milestone: | --- | ||
Platform: | Mandriva RPMs | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | 2.3.1 | |
Attachments: | screenshot of Amarok config dialogue |
Description
Cyril Brosch
2010-04-08 18:06:39 UTC
Created attachment 42600 [details]
screenshot of Amarok config dialogue
Amarok version? Does it only happen using German locales? It's Amarok 2.3. The English version is only half that wide. Comparing the dialogues I guess that there are only two lines reserved for the long description in the collection section. The English text is much shorter there, while the text in the data base section has more or less the same length as with German locales. That is indeed problematic. I'll see if we can fix it by setting a flag for automatic word wrap (line breaks). commit 80aef22f53352461ff77778faa73fd1b99823761 Author: Mark Kretschmann <kretschmann@kde.org> Date: Sat Apr 10 09:35:12 2010 +0200 Use word wrap in collection settings to prevent huge width. One label caused issues with translated versions of Amarok: The whole dialog would become extremely wide, depending on the length of the translated text. I've enabled word wrap to fix this. BUG: 233752 diff --git a/ChangeLog b/ChangeLog index 1275dfe..da78a03 100644 --- a/ChangeLog +++ b/ChangeLog @@ -54,6 +54,7 @@ VERSION 2.3.1-Beta 1 some MySQL versions. (BR 225052) BUGFIXES: + * Settings dialog could become too wide with translations. (BR 233752) * Fix re-mounting iPhoneOS devices after having been unplugged without being unmounted. Thanks to Jeffrey Dodge <hazridi@gmail.com>. (BR 233305) * Fix connecting to iPod Touch devices. Patch by Jeffrey Dodge diff --git a/src/dialogs/CollectionSetup.cpp b/src/dialogs/CollectionSetup.cpp index 048de21..087505b 100644 --- a/src/dialogs/CollectionSetup.cpp +++ b/src/dialogs/CollectionSetup.cpp @@ -92,11 +92,13 @@ CollectionSetup::CollectionSetup( QWidget *parent ) setObjectName( "CollectionSetup" ); s_instance = this; - (new QLabel( i18n( + QLabel* descriptionLabel = new QLabel( i18n( "These folders will be scanned for " - "media to make up your collection. You can\n" + "media to make up your collection. You can " "right-click on a folder to individually " - "rescan it, if it was previously selected:"), this ))->setAlignment( Qt::AlignJustify ); + "rescan it, if it was previously selected:" ), this ); + descriptionLabel->setAlignment( Qt::AlignJustify ); + descriptionLabel->setWordWrap( true ); m_view = new CollectionSetupTreeView( this ); m_view->setHeaderHidden( true ); |