Bug 233712

Summary:	Assigning shortcut to Show toolbar action
Product:	[Unmaintained] kdelibs	Reporter:	Terényi, Balázs <balazs>
Component:	general	Assignee:	kdelibs bugs <kdelibs-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	faure, whynot
Priority:	NOR
Version First Reported In:	0.1
Target Milestone:	---
Platform:	unspecified
OS:	Linux
Latest Commit:		Version Fixed/Implemented In:	4.6
Sentry Crash Report:

Description Terényi, Balázs 2010-04-08 11:14:40 UTC

Version:           0.10.2 (using 4.4.2 (KDE 4.4.2) "release 231", KDE:KDE4:Factory:Desktop / openSUSE_11.0)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.25.20-0.7-default

Show toolbar action's keyboard shortcut can not be assigned. This action is missing from the list on "Configure shortcut" window.

Thanks,
Balázs

Comment 1 Albert Astals Cid 2010-04-20 20:26:52 UTC

Not an okular specific bug.

Comment 2 Hannes Schniepp 2010-07-01 14:23:17 UTC

I have dearly missed this feature for many kubuntu/KDE releases, as well. Also, if you right-click the corresponding menu function "Settings -> Show Toolbar", I get an option "Configure Shortcut". This feature works, I can assign a shortcut. However, this is not persistent: if okular is closed and restarted, the shortcut has been "forgotten". 

@Albert: your comments sounds a bit like "Not my job."  I am not familiar enough with the guts of KDE to be able to tell where else to submit this bug/shortcoming/feature request. Would you mind spending a few more seconds of your time telling us what our best option is in order to communicate our feedback/observation with the KDE community? Thank you so much.

Comment 3 David Faure 2010-10-19 22:43:24 UTC

Albert was merely explaining why he reassigned the bug from okular to kdelibs.

I'll have a look at fixing the bug.

Comment 4 David Faure 2010-10-19 23:07:49 UTC

SVN commit 1187602 by dfaure:

Allow action collections without an XML file in the shortcut editor; we have code already for saving the shortcuts to KConfig.
OTOH we need to make sure to call readSettings() on such collections - doing so for the toolbar actions, probably missing in
 other cases too...
FIXED-IN: 4.6
BUG: 233712


 M  +4 -0      ktoolbarhandler.cpp  
 M  +3 -3      kxmlguifactory.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1187602