Bug 233657

Summary: thumbnails are created for thumbnails
Product: [Applications] digikam Reporter: Zeev Tarantov <zeev.tarantov>
Component: Showfoto-ThumbsAssignee: Digikam Developers <digikam-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: caulier.gilles, mohammed.ahmed.anwer, praveshgupta1993
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Linux   
Latest Commit: Version Fixed In: 4.0.0

Description Zeev Tarantov 2010-04-07 23:46:10 UTC
Version:           1.2.0 (using KDE 4.4.2)
Compiler:          gcc 4.4.3 amd64, gentoo patched
OS:                Linux
Installed from:    Gentoo Packages

Xzibit: Yo dawg, I heard you liked thumbnails, so I made thumbnails for your thumbnails so you can fill up your disk while you...

(see: of http://knowyourmeme.com/memes/xzibit-yo-dawg)

How to reproduce:

$ mv ~/.thumbnails/large ~/.thumbnails/large.orig

$ mkdir -p ~/.thumbnails/large

$ ls -laF ~/.thumbnails/large
total 0
drwxr-xr-x 2 wolf wolf  48 Apr  8 00:23 ./
drwx------ 5 wolf wolf 128 Apr  8 00:23 ../

$ showfoto ~/Pictures/bunny.jpg

(see copy of http://2.bp.blogspot.com/_UPiDqGJQuaY/SfV5iYetnMI/AAAAAAAAApw/CTKc8JKoSd0/s400/25ySQ.jpg , close showfoto)

$ ls -laF ~/.thumbnails/large
total 100
drwxr-xr-x 2 wolf wolf   104 Apr  8 00:24 ./
drwx------ 5 wolf wolf   128 Apr  8 00:23 ../
-rw------- 1 wolf wolf 99788 Apr  8 00:24 d44d8ab4487ccca6651e7ebe6734e70c.png

$ showfoto ~/.thumbnails/large/d44d8ab4487ccca6651e7ebe6734e70c.png

(see thumbnail of picture)

$ ls -laF ~/.thumbnails/large
total 200
drwxr-xr-x 2 wolf wolf   160 Apr  8 00:24 ./
drwx------ 5 wolf wolf   128 Apr  8 00:23 ../
-rw------- 1 wolf wolf 99827 Apr  8 00:24 831da54fde4643669f01e190390b623a.png
-rw------- 1 wolf wolf 99788 Apr  8 00:24 d44d8ab4487ccca6651e7ebe6734e70c.png

Oh, what a surprise! What is this new thumbnail?

$ showfoto ~/.thumbnails/large/831da54fde4643669f01e190390b623a.png

It's a thumbnail of a thumbnail! Could I get more? Yes, you can continue until your disk is full.

Also, the value of the key Thumb::URI in 831da54fde4643669f01e190390b623a.png is file:///home/wolf/.thumbnails/large/d44d8ab4487ccca6651e7ebe6734e70c.png

So, how about not creating thumbnails for thumbnails, please?
Comment 1 Pravesh Gupta 2013-04-30 16:22:31 UTC
i think that  Before generating the thumb-nails , we can check in the thumb-nail directory , if there is any prior image ,with "same pixmap", already existing . if so , we don't generate the thumbnail for it ,  and use the "already created" thumb-nail.
it will require a change in the thumbnailbasic.cpp .