Bug 233654

Summary:	Time check box can be unchecked when editing a journal entry
Product:	[Applications] korganizer	Reporter:	Sabine Faure <sabine>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	VERIFIED FIXED
Severity:	normal
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:

Description Sabine Faure 2010-04-07 23:06:36 UTC

Version:            (using Devel)
Compiler:          gcc 4.3.2 
OS:                Linux
Installed from:    Compiled sources

- Launch KOrg
- Click on 'New Journal' button
- Select a calendar, enter a name and a date
- Uncheck the time check box and the combo box becomes greyed
- Enter a small description 
- Click on Ok

The journal entry is created and displayed correctly on the proper day.

- Now click on the 'Edit' button underneath the journal entry you've just created
- Recheck the 'Time:' check box and enter a time in the combo box
- Click on 'Ok'

The journal entry is now displaying a time

- Click on the 'Edit' button again
- Uncheck the 'Time:' check box
- Click on 'Ok'

The 'Edit Journal' dialogue is not closing. 

I think it should not be possible to uncheck the 'Time:' check box if it is impossible to click on 'Ok' afterwards.

Atm the only way to close the dialogue again is to click on 'Cancel' or to recheck the 'Time:' check box.

Trunk, Svn Rev 1112300

Comment 1 Sergio Martins 2010-05-15 15:53:24 UTC

SVN commit 1127088 by smartins:

When caching items by date, don't have duplicate item's with different revisions.

That causes some STORE bugs and was also the reason why we couldn't edit journals sometimes.

BUG: 233654



 M  +35 -26    calendar.cpp  
 M  +1 -1      calendar_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1127088

Comment 2 Sabine Faure 2010-05-18 16:33:17 UTC

It is corrected now.

The Edit journal dialogue can be closed properly now.

Trunk, Svn Rev 1128166