| Summary: | Crash after right click in the terminal area [detach*, QList<QWidget*>::removeAll, QWidget::removeAction, Konsole::SessionController::showDisplayContextMenu] | ||
|---|---|---|---|
| Product: | [Applications] konsole | Reporter: | auxsvr |
| Component: | general | Assignee: | Konsole Developer <konsole-devel> |
| Status: | RESOLVED FIXED | ||
| Severity: | crash | CC: | adaptee, andresbajotierra, chaos.proton, francesco.cecconi, grgoffe, jamel.maison, lorek123, maxposedon, moilinki, p.giarrusso, peter, roger.rotge, stephan.menzel |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | openSUSE | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | 4.8 | |
| Attachments: |
New crash information added by DrKonqi
New crash information added by DrKonqi patch for kde 4.6 fix for kde 4.7 |
||
|
Description
auxsvr
2010-04-05 18:10:59 UTC
This just occurred in KDE 4.4.3. *** Bug 254450 has been marked as a duplicate of this bug. *** *** Bug 238244 has been marked as a duplicate of this bug. *** *** Bug 235697 has been marked as a duplicate of this bug. *** Created attachment 56420 [details]
New crash information added by DrKonqi
konsole (2.5) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0
- What I was doing when the application crashed:
While I've several tabs open, I accidentally scrolled over the tabs with a contextmenu from the terminal area open which caused an unexpected crash.
Steps to reproduce:
1. Open at least two terminal tabs.
2. Open a contextmenu by rightclicking in the terminal area.
3. Scroll on the tabs with the contextmenu open.
4. Konsole crashes
-- Backtrace (Reduced):
#6 operator!= (this=0x1d27d90, action=0x1bd7ef0) at ../../include/QtCore/../../src/corelib/thread/qbasicatomic.h:75
#7 detachShared (this=0x1d27d90, action=0x1bd7ef0) at ../../include/QtCore/../../src/corelib/tools/qlist.h:131
#8 removeAll (this=0x1d27d90, action=0x1bd7ef0) at ../../include/QtCore/../../src/corelib/tools/qlist.h:757
#9 QWidget::removeAction (this=0x1d27d90, action=0x1bd7ef0) at kernel/qwidget.cpp:3167
#10 0x00007f87e10b437a in Konsole::SessionController::showDisplayContextMenu (this=0x1735c30, position=<value optimized out>) at ../../../../apps/konsole/src/SessionController.cpp:1086
Created attachment 58208 [details]
New crash information added by DrKonqi
konsole (2.6.1) on KDE Platform 4.6.1 (4.6.1) using Qt 4.7.2
- What I was doing when the application crashed:
Same thing as the original poster. I guess it could have even been 7 shells. Load was about 5.
Very.
Very.
Very inconvenient indeed.
-- Backtrace (Reduced):
#7 0x00007f4fc7d28be2 in Konsole::SessionController::showDisplayContextMenu (this=0x1b6aad0, position=<value optimized out>) at /var/tmp/portage/kde-base/konsole-4.6.1/work/konsole-4.6.1/konsole/src/SessionController.cpp:1088
#8 0x00007f4fc7d2d851 in Konsole::SessionController::qt_metacall (this=0x1b6aad0, _c=QMetaObject::InvokeMetaMethod, _id=28, _a=0x7fff0f2b64c0) at /var/tmp/portage/kde-base/konsole-4.6.1/work/konsole-4.6.1_build/konsole/src/SessionController.moc:175
[...]
#10 0x00007f4fc7d41d73 in Konsole::TerminalDisplay::configureRequest (this=<value optimized out>, _t1=<value optimized out>) at /var/tmp/portage/kde-base/konsole-4.6.1/work/konsole-4.6.1_build/konsole/src/TerminalDisplay.moc:191
#11 0x00007f4fc7d43c7f in Konsole::TerminalDisplay::mousePressEvent (this=0x1bb1600, ev=0x7fff0f2b6fc0) at /var/tmp/portage/kde-base/konsole-4.6.1/work/konsole-4.6.1/konsole/src/TerminalDisplay.cpp:1756
#12 0x00007f4fd80fdab5 in QWidget::event (this=0x1bb1600, event=0x7fff0f2b6fc0) at kernel/qwidget.cpp:8255
[Comment from a bug triager] From bug 271180 (KDE SC 4.6.2): -- Information about the crash: I was trying to run the KDE wiget Easy SSH Connection and it closes before I can see the error. I right clicked on the window before it closed in the hopes of keeping it open when Konsole crashed. *** Bug 271180 has been marked as a duplicate of this bug. *** I can't reproduce on my KDE 4.6.2/3/trunk. When the context menu open, when I scroll middle button, the menu just closes. *** Bug 273334 has been marked as a duplicate of this bug. *** I can reproduce this each time with konsole-2.7.999, by following the steps in comment #5. The step 3 in comment #5 is not described very clearly. In that step, 'Scroll' means (while context menu is still open) moving mouse above tab bar and using mouse wheel to switch active tab, not scrolling above the terminal display or context menu. Created attachment 63353 [details]
patch for kde 4.6
Created attachment 63354 [details]
fix for kde 4.7
Hi, these patches [1] [2] fix the bug in kde 4.6 and 4.7 [1]: https://bugs.kde.org/attachment.cgi?id=63353 [2]: https://bugs.kde.org/attachment.cgi?id=63354 Best Regards, Francesco sorry the patch [2] is for the master branch, but for 4.7 is the same problem. (In reply to comment #15) > Francesco, your patch does fix this crash, but it also causes regression. For example, move mouse above an URL and invoke context menu, the context menu contains action for opening this URL. Then move the mouse above some normal text and invoke context menu again, the context menu still contains the action for opening URL. Those commented 3 lines are supposed to do something useful. Simply commenting them is not the right fix. Thanks for your help, anyway. (In reply to comment #16) > (In reply to comment #15) > > > > Francesco, your patch does fix this crash, but it also causes regression. > > For example, move mouse above an URL and invoke context menu, the context menu > contains action for opening this URL. Then move the mouse above some normal > text and invoke context menu again, the context menu still contains the action > for opening URL. > > Those commented 3 lines are supposed to do something useful. Simply commenting > them is not the right fix. The problem is that, the "popoup" isn't usable after switch tab with mouse wheel and the call popup->removeAction(action), crash the application. But my path is not a right fix :) > > Thanks for your help, anyway. Best Regards. Git commit 0f89f1bba96163ab5dd37ab974927b5566439d36 by Jekyll Wu. Committed on 05/09/2011 at 22:12. Pushed by jekyllwu into branch 'master'. Check the validity of context menu after it gets closed. The patch is from Francesco Cecconi <francesco.cecconi@gmail.com>, with slight modification by committer. BUG: 233377 FIXED-in : 4.8 M +14 -6 src/SessionController.cpp http://commits.kde.org/konsole/0f89f1bba96163ab5dd37ab974927b5566439d36 Actually, that commit will not delete contentSeparator if popup menu got destroyed early. Thus cause a memory leak. I think the right thing is connect QMenu's destroy signal to that cleanup codes. But to achieve that, I think we need to pass contentActions to that function. That will lead to ugly code I think. Is there a way to use lambda function in this situation? ;P Hi Grissom, when popup menu is distroyed "early" all action are cleared correctly included contentAction and contentSeparator. I have monitored contentSeparator with QSharedPointer. Git commit 000f84299c00e782dda75244d5daf35e1c88794c by Kurt Hindenburg, on behalf of Jekyll Wu. Committed on 05/09/2011 at 22:12. Pushed by hindenburg into branch 'KDE/4.7'. Check the validity of context menu after it gets closed. The patch is from Francesco Cecconi <francesco.cecconi@gmail.com>, with slight modification by committer. BUG: 233377 FIXED-in : 4.8 (cherry picked from commit 0f89f1bba96163ab5dd37ab974927b5566439d36) M +14 -6 src/SessionController.cpp http://commits.kde.org/konsole/000f84299c00e782dda75244d5daf35e1c88794c *** Bug 283962 has been marked as a duplicate of this bug. *** *** Bug 289652 has been marked as a duplicate of this bug. *** |