Summary: | Plasma does not allow ico files in filter for setting shortcut icon | ||
---|---|---|---|
Product: | [Frameworks and Libraries] frameworks-kiconthemes | Reporter: | Patrick Noffke <patrick.noffke> |
Component: | general | Assignee: | Christoph Feck <cfeck> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | bugseforuns, kdelibs-bugs, nate, rob.townley+KDE |
Priority: | NOR | Keywords: | junior-jobs |
Version: | 5.47.0 | ||
Target Milestone: | --- | ||
Platform: | Fedora RPMs | ||
OS: | Linux | ||
Latest Commit: | https://commits.kde.org/kiconthemes/0131f8afe845f077e525a87e0b168f6600691fe6 | Version Fixed In: | 5.48 |
Description
Patrick Noffke
2010-04-03 21:42:53 UTC
The website pbsKidsPlay.org uses .ICO as favicon.ico. i created shortcuts to pbsKidsPlay.org under plasma so that the 2 year old can easily see where to click. It works under CentOS 6 Gnome, but not plasma. Fails under CentOS 6 kdebase-4.3.4-5.el6 not plasma. Patch available: https://phabricator.kde.org/D13718 Git commit 0131f8afe845f077e525a87e0b168f6600691fe6 by Nathaniel Graham. Committed on 27/06/2018 at 21:15. Pushed by ngraham into branch 'master'. Support choosing .ico files in custom icon file chooser Summary: .ico files work fine, so we should allow them to be chosen in the custom icon file chooser dialog. FIXED-IN: 5.48 Test Plan: - Find a .ico file lying around, or turn a .png file into a .ico file using https://convertico.com/ - Typ to apply it to a folder in Dolphin - You can select the .ico file in the dialog, and when applied, it appears correctly as a custom icon for the folder Reviewers: #frameworks, cfeck Reviewed By: cfeck Subscribers: broulik, kde-frameworks-devel Tags: #frameworks Differential Revision: https://phabricator.kde.org/D13718 M +2 -2 src/kicondialog.cpp https://commits.kde.org/kiconthemes/0131f8afe845f077e525a87e0b168f6600691fe6 Rob, your 2 year-old is now 8, but hopefully this will still be useful. :) |