Bug 232757

May be not "Planning" but "Payments" - i can't find how to switch program interface from Russian to English. On Russian it is "Платежи" и закладка "Календарь"

That would be Scheduled Transactions.
Could you try with the newer version, 3.97?

SVN commit 1113328 by conet:

BUG: 232757
Make sure that an improper translation will not cause a crash.

 M  +5 -2      kmymoneyscheduleddatetbl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1113328

Thank you, Alvaro.
There is no this bug On 3.97.2, but i try new version without russian interface, only with engish one.

Created attachment 51106 [details]
New crash information added by DrKonqi

kmymoney (4.5.0) on KDE Platform 4.5.00 (KDE 4.5.0) using Qt 4.6.3

Every time i try to open Calendar View tab in Scheduled Transactions kmymoney was crashed. It happen only in Russian interface.

-- Backtrace (Reduced):
#7  QString::append (this=0xbff0df64, str=@0x8fc49b8) at tools/qstring.cpp:1455
#8  0x08384d61 in kMyMoneyScheduledDateTbl::addDayPostfix(QString&) ()
#9  0x08385ebf in kMyMoneyScheduledDateTbl::drawCellContents(QPainter*, QStyleOptionViewItem const&, QModelIndex const&, QDate const&) ()
#11 0xb5e045d7 in QTableViewPrivate::drawCell (this=0x891f3a8, painter=0xbff0e3e4, option=..., index=...) at itemviews/qtableview.cpp:935
#12 0xb5e10f1a in QTableView::paintEvent (this=0x891f2e0, event=0x8fcd388) at itemviews/qtableview.cpp:1407

Can someone else confirm this happening on a non-Russian translated interface or is this specific to that language?

I scanned the source and found out, that the russian kmymoney.po contains the following section:

#: kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:273
msgctxt ""
"These are the suffix strings of the days in the calendar view; please make "
"sure that you keep all the 30 separators (the '-' character) when translating"
msgid ""
"st-nd-rd-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-st-nd-rd-th-th-"
"th-th-th-th-th-st"
msgstr " "

whereas the German on contains:

#: kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:273
msgctxt ""
"These are the suffix strings of the days in the calendar view; please make "
"sure that you keep all the 30 separators (the '-' character) when translating"
msgid ""
"st-nd-rd-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-th-st-nd-rd-th-th-"
"th-th-th-th-th-st"
msgstr "------------------------------"

The comment says to keep the 30 dashes, but in the russian version they are gone. Could that lead to the problem?

Yes, that's probably the problem. Is it absolutely necessary to have that string as translatable string?

SVN commit 1170476 by asoliverez:

Skip the postDay suffix calculation if a string is not translated correctly

BUG:232757

 M  +5 -3      kmymoneyscheduleddatetbl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1170476

Hi,

I've already fixed this previously but it seems that I've fixed it the wrong way :) see the comment "// make sure that an improper translation will not cause a crash" and this diff http://websvn.kde.org/trunk/extragear/office/kmymoney/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp?r1=1079021&r2=1113328&pathrev=1170476

The current solution still has the BUG I've introduced then:
" if (postfixList.size() <= d) " should actually be
" if (d <= postfixList.size()) " and then the last change of Alvaro can also be reverted.

In the current implementation I think that suffixes are not visible since "postfixList.size() <= d" always evaluates to false (it's correct only when d=31).

Can someone fix this please?

SVN commit 1170518 by asoliverez:

Reverted previous fixed and done as per Cristian's suggestion.

BUG:232757

 M  +4 -6      kmymoneyscheduleddatetbl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1170518

SVN commit 1170521 by asoliverez:

Backported fix to stable branch

BUG:232757

 M  +1 -1      kmymoneyscheduleddatetbl.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1170521

Created attachment 52124 [details]
New crash information added by DrKonqi

kmymoney (4.5.0) on KDE Platform 4.5.1 (KDE 4.5.1) using Qt 4.7.0

- What I was doing when the application crashed:

Платежи - Календарь - crashed

Ошибка повторяется постоянно. Способ устранения не понятен, если не собирать из исходников.

-- Backtrace (Reduced):
#7  0xb5725d86 in QString::append(QString const&) () from /usr/lib/libQtCore.so.4
#8  0x083d6c46 in operator+= (this=0x92be428, text=...) at /usr/include/qt4/QtCore/qstring.h:281
#9  kMyMoneyScheduledDateTbl::addDayPostfix (this=0x92be428, text=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:275
#10 0x083d83a8 in kMyMoneyScheduledDateTbl::drawCellContents (this=0x92be428, painter=0xbfc2f794, option=..., index=..., theDate=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:106
#11 0x085a1789 in KMyMoneyDateTbDelegate::paint (this=0x92ca150, painter=0xbfc2f794, option=..., index=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneydatetbl.cpp:181

Created attachment 55266 [details]
New crash information added by DrKonqi

kmymoney (4.5.0) on KDE Platform 4.5.4 (KDE 4.5.4) using Qt 4.7.0

- What I was doing when the application crashed:

I selected "Scheduled transactions" -> "Calendar View" and got a crash.
It happends every time. I can't see "Calendar View" at all.

(KMyMoney 4.5.0 KDE 4.5.4)

-- Backtrace (Reduced):
#7  0x023a4d86 in QString::append (this=0xbff76d2c, str=...) at tools/qstring.cpp:1499
#8  0x083d6c46 in operator+= (this=0x8df1220, text=...) at /usr/include/qt4/QtCore/qstring.h:281
#9  kMyMoneyScheduledDateTbl::addDayPostfix (this=0x8df1220, text=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:275
#10 0x083d83a8 in kMyMoneyScheduledDateTbl::drawCellContents (this=0x8df1220, painter=0xbff77194, option=..., index=..., theDate=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:106
#11 0x085a1789 in KMyMoneyDateTbDelegate::paint (this=0x8df9228, painter=0xbff77194, option=..., index=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneydatetbl.cpp:181

Did you try KMyMoney 4.5.2? This has been fixed already.

> Did you try KMyMoney 4.5.2? This has been fixed already.
I'm sorry I missed new version. In 4.5.2 everything is OK.

Created attachment 63055 [details]
New crash information added by DrKonqi

kmymoney (4.5.0) on KDE Platform 4.6.2 (4.6.2) using Qt 4.7.0

- What I was doing when the application crashed:

All the same: clicking on tab «planning calendar»

This still happens with russian translation…

-- Backtrace (Reduced):
#7  0x026f5d86 in QString::append (this=0xbf8aa48c, str=...) at tools/qstring.cpp:1499
#8  0x083d6c46 in operator+= (this=0xb442f80, text=...) at /usr/include/qt4/QtCore/qstring.h:281
#9  kMyMoneyScheduledDateTbl::addDayPostfix (this=0xb442f80, text=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:275
#10 0x083d83a8 in kMyMoneyScheduledDateTbl::drawCellContents (this=0xb442f80, painter=0xbf8aa8f4, option=..., index=..., theDate=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneyscheduleddatetbl.cpp:106
#11 0x085a1789 in KMyMoneyDateTbDelegate::paint (this=0xb212b10, painter=0xbf8aa8f4, option=..., index=...) at /build/buildd/kmymoney-4.5/kmymoney/widgets/kmymoneydatetbl.cpp:181

Please, update to KMyMoney version 4.5.3 or 4.6.0