| Summary: | Kdevelop doesn't behave well when renaming opened files from IDE | ||
|---|---|---|---|
| Product: | [Developer tools] kdevplatform | Reporter: | Valentyn Pavliuchenko <valentyn.pavliuchenko> |
| Component: | shell | Assignee: | kdevelop-bugs-null |
| Status: | CLOSED FIXED | ||
| Severity: | wishlist | CC: | aleixpol, niko.sams |
| Priority: | NOR | ||
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Platform: | Debian testing | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Valentyn Pavliuchenko
2010-03-28 23:57:46 UTC
As for me, it's rather a bug than a wish. From the technical point of view it is a new feature. Sorry, but it's just incomplete rename functionality. This is part of "rename" functionality. No its not, "rename file xyz to foo" works as it should, renaming works. Anyway, wether this is listed as bug or wish doesn't increase its priority in any way, so it won't be fixed sooner if listed as bug. Well, it is a difference as we are in feature freeze... And I want to implement this. Should I wait for after 4.0? Yes. And it should work no matter wether the rename happens inside kdevelop or outside of it (for a plain rename, not a move) Yes, I was talking about bug/with status because of feature freeze.
I've asked few people around me, shown them a problem and they all said that it's definitely a bug.
>And it should work no matter wether the rename happens inside kdevelop or
outside of it
It would be good, but it's not as necessary as renaming inside IDE.
(In reply to comment #7) > >And it should work no matter wether the rename happens inside kdevelop or > outside of it > > It would be good, but it's not as necessary as renaming inside IDE. The implementation needs to be independent of the IDE doing the renaming or the same happening on the filesystem. Else we'll be getting the same bugreport 2 weeks after fixing because somebody does an svn up or git merge and that renames something. Thats not an option, if this is implemented it needs to be done right. Can we detect a move outside kdevelop? Including the location it was moved to? (In reply to comment #9) > Can we detect a move outside kdevelop? Including the location it was moved to? Hmm, looks like we can't, I thought this was available via KDirWatch, but that one only knows deleted/created/changed signals. Ok, so only renaming inside the IDE will be supported. Niko, can you look into how much changes this needs? I'm willing to take it as bug instead of feature if the change is not too intrusive/big. (In reply to comment #10) > Niko, can you look into > how much changes this needs? I'm willing to take it as bug instead of feature > if the change is not too intrusive/big. Listening to IProjectFileManager::fileRenamed signal in DocumentController and closing and opening the renamed file. But afaics this signal is never emitted? Guys, of course you are developers and you know better, but can it be done without closing/opening? (In reply to comment #12) > Guys, of course you are developers and you know better, but can it be done > without closing/opening? Not without changing Kate, so thats definetly something for KDevelop4.1 (which then would need to depend on KDE 4.5 - if this is done inside Kate for kde4.5) (In reply to comment #11) > (In reply to comment #10) > > Niko, can you look into > > how much changes this needs? I'm willing to take it as bug instead of feature > > if the change is not too intrusive/big. > Listening to IProjectFileManager::fileRenamed signal in DocumentController and > closing and opening the renamed file. But afaics this signal is never emitted? Yeap, its never emitted, however that really is a bugfix. That solution sounds simple enough, so changing this to bug to allow it being for 4.0 Can you fill a wish for Kate? Better to record this idea:) Git commit 38ab0d0878e027777608c437980a28ba7bb53208 by Aleix Pol. Committed on 07/08/2011 at 15:36. Pushed by apol into branch 'master'. Make the document controller to listen to the project's so that whenever an open file is renamed, that file should be closed and reopened with the new name. BUG: 232520 M +23 -0 shell/documentcontroller.cpp M +4 -1 shell/documentcontroller.h http://commits.kde.org/kdevplatform/38ab0d0878e027777608c437980a28ba7bb53208 Just compiled sources (this fix included). Renaming modified file causes loosing unsaved changes without any notice. So I'm reopening this because of incorrect behavior. This is the place where reopening just sucks. Please find a way to do it without closing/opening document (kate kpart changes, etc). Every normal IDE just renames a tab. I just fixed the discard thing, so that you don't lose any changes. The other complaint should be reported in a new bug report. Verified - fine now. Thanks. |