Bug 232450

Summary: Douarnenez (France) [and possibly other places to] is in a wrong place
Product: [Applications] marble Reporter: Bastian Senst <bastianholst>
Component: generalAssignee: Harshit Jain <hjain.itbhu>
Status: RESOLVED FIXED    
Severity: normal CC: hjain.itbhu, marble-bugs, nigelbabu
Priority: NOR    
Version: unspecified   
Target Milestone: 0.8 (KDE 4.3)   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed In:
Sentry Crash Report:
Attachments: A patch to fix this city's problem

Description Bastian Senst 2010-03-28 12:31:10 UTC 
Version:            (using Devel)
Installed from:    Compiled sources

The city of Douarnenez (France) is mirrored at the Prime Meridian due to a missing '-' sign in the data file.
The position is correct in the current version of http://www.world-gazetteer.com and geonames.

This could also affect other places.
Comment 1 Nigel Babu 2010-03-28 16:37:12 UTC 
Created attachment 42312 [details]
A patch to fix this city's problem
Comment 2 Bastian Senst 2010-03-29 13:48:29 UTC 
(In reply to comment #1)
> Created an attachment (id=42312) [details]
> A patch to fix this city's problem

Hi Nigel Babu,

this shouldn't fix the problem or could lead to other problems. Read /data/placemarks/HOWTO-cities.txt [1] for more information.

Best Regards
Bastian

[1] http://websvn.kde.org/*checkout*/trunk/KDE/kdeedu/marble/data/placemarks/HOWTO-cities.txt?revision=774902
Comment 3 Bastian Senst 2010-06-06 17:31:06 UTC 
SVN commit 1135143 by bholst:

Patch by Harshit Jain:
Marble now uses Geonames.org for city placemarks to fix several bugs in the placemark file.

CCBUG: 240622
CCBUG: 232450

 M  +10 -17    data/placemarks/COPYRIGHT  
 M  +6 -6      data/placemarks/HOWTO-cities.txt  
 M             data/placemarks/boundaryplacemarks.cache  
 M  +21656 -22583 data/placemarks/cities.txt  
 M             data/placemarks/cityplacemarks.cache  
 M  +127527 -138237 data/placemarks/cityplacemarks.kml  
 A             data/placemarks/statecodes.txt  
 M  +32 -20    src/lib/FileLoader.cpp  
 M  +0 -1      src/lib/MarbleDirs.cpp  
 M  +34 -51    src/lib/PlacemarkInfoDialog.cpp  
 M  +1 -1      src/lib/PlacemarkLayout.cpp  
 M  +43 -40    src/lib/PlacemarkManager.cpp  
 M  +2 -2      src/lib/geodata/data/GeoDataFeature.cpp  
 M  +2 -3      src/lib/geodata/data/GeoDataFeature.h  
 M  +2 -2      src/lib/geodata/data/GeoDataFeature_p.h  
 M  +0 -3      src/lib/geodata/data/GeoDataPlacemark.cpp  
 U             src/lib/geodata/data/GeoDataPlacemark_p.h  
 M  +1 -1      src/lib/geodata/data/GeoDataStyleMap.cpp  
 M  +1 -2      src/lib/geodata/handlers/kml/KmlRoleTagHandler.cpp  
 M  +1 -1      src/lib/geodata/parser/GeoDataTypes.cpp  
 M  +1 -1      src/lib/geodata/parser/GeoDataTypes.h  
 M  +49 -12    tools/asc2kml/asc2kml.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1135143