Bug 232348

Summary: Improve the layout of items in the wallpaper selection
Product: [Plasma] plasma4 Reporter: Elias Probst <mail>
Component: containment-desktopAssignee: Plasma Bugs List <plasma-bugs>
Status: RESOLVED FIXED    
Severity: wishlist CC: andresbajotierra
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Gentoo Packages   
OS: Unspecified   
Latest Commit: Version Fixed In:
Attachments: Screenshot highlighting the described issues of the report.
Screenshot showing further alignment issues in the wallpaper dialog.

Description Elias Probst 2010-03-27 14:43:21 UTC 
Version:            (using KDE 4.4.1)
Installed from:    Gentoo Packages

The layout of the items in the wallpaper could be improved in 2 points (see the attached screenshot for reference):

1#
Align the text belonging to the wallpaper thumbnail vertically centered.
Currently the alignment doesn't follow any common boundaries or common centers.
By making sure the border above and below the item is equal the placement of the text would look way better and more clean.

2#
Make use of the full width of the colum for the text.
Currently, the text is wrapped after ~1/3rd of the colum width.
This pushes the lower bottom of the text unnecessarily downwards while it makes the whole layout look cluttered.
When using a linebreak if necessary it should be made sure, the top/bottom alignment is still correct (see #1).

3# Alternative for #1:
Give the alignment of the image and the text a common bottom. Currently the text is positioned too low.
This alternative isn't that streamlined as #1, because when a long text causes a linewrap, the whole layout balance is destroyed again.
Comment 1 Elias Probst 2010-03-27 14:44:14 UTC 
Created attachment 42291 [details]
Screenshot highlighting the described issues of the report.
Comment 2 Dario Andres 2010-03-28 18:37:00 UTC 
Fix proposal at http://reviewboard.kde.org/r/3417
Comment 3 Elias Probst 2010-03-28 21:55:11 UTC 
Created attachment 42323 [details]
Screenshot showing further alignment issues in the wallpaper dialog.

Wow, this was a really fast fix - thank you! The changes look great so far. Didn't have the time yet to actually testing them.

Unfortunately I found 2 more layout issues in the dialog. Maybe you'll find time to look at this too (see attached screenshot).

Thanks a lot!
Comment 4 Dario Andres 2010-03-29 00:37:41 UTC 
The last issue you mentioned would be more difficult to fix because, technically, the first combobox and the other elements below belong to two different widgets.

The Type combobox let's you choose which kind of wallpaper to use. And each kind of wallpaper has its own configuration widget. (try changing the Type, and the widgets below will change)

May be there is a way to standarize the margins or something...
Comment 5 Aaron J. Seigo 2010-03-29 23:17:27 UTC 
SVN commit 1108826 by aseigo:

wallpaper selector in a grid, fix up various painting issues with the text based on a patch by Darío Andrés
BUG:232348


 M  +64 -57    backgrounddelegate.cpp  
 M  +5 -2      backgrounddelegate.h  
 M  +16 -6     backgroundlistmodel.cpp  
 M  +1 -0      backgroundlistmodel.h  
 M  +5 -54     image.cpp  
 M  +0 -2      image.h  
 M  +14 -48    imageconfig.ui  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108826
Comment 6 Elias Probst 2010-03-30 11:50:11 UTC 
Great!
Thanks a lot Aaron and Dario!