Bug 231960

Summary: kexi: bashism in /bin/sh script
Product: [Applications] KEXI Reporter: Eckhart Wörner <ewoerner>
Component: GeneralAssignee: Jarosław Staniek <staniek>
Status: CLOSED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Unspecified   
Latest Commit: Version Fixed In:

Description Eckhart Wörner 2010-03-24 02:56:06 UTC
Version:            (using Devel)
Installed from:    Compiled sources

This bug has been copied over from http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=530977 and has been verified to still exist in KOffice trunk

----

Hello maintainer,

While performing an archive wide checkbashisms (from the 'devscripts' package)
check I've found your package containing a /bin/sh script making use
of a bashism.

checkbashisms' output:
> possible bashism in ./usr/bin/kexi_delete_column_gui line 32 (should be
> '.', not 'source'):
>			  source "$transl_file"
> possible bashism in ./usr/bin/kexi_delete_column_gui line 41 (should be
> '.', not 'source'):
>		  if [ -f "$transl_file" ] ; then source "$transl_file"; else
> transl_file=; fi
> possible bashism in ./usr/bin/kexi_add_column_gui line 32 (should be '.',
> not 'source'):
>			  source "$transl_file"
> possible bashism in ./usr/bin/kexi_add_column_gui line 41 (should be '.',
> not 'source'):
>		  if [ ! -f "$transl_file" ] ; then	  source
> "$transl_file"; else transl_file=; fi


Not using bash (or a Debian Policy conformant shell interpreter which doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours.
Please be aware that although bash is currently the default /bin/sh there was
a release goal for Lenny to make dash the default /bin/sh[1], and has been
proposed for squeeze as well[2].

If you want more information about dash as /bin/sh, you can read:
http://lists.debian.org/debian-release/2008/01/msg00189.html

For more information supporting this goal please refer to Debian Policy,
section 10.4, at:
http://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Hints about how to fix bashisms:
Sometimes these bugs are already fixed in Ubuntu, look at the PTS.
If not already fixed you can read:
https://wiki.ubuntu.com/DashAsBinSh

If you still don't know how to fix the bashisms don't hesitate to reply to
this email, or tag the bug as 'help'.

[1]http://release.debian.org/lenny/goals.txt
[2]http://lists.debian.org/debian-release/2009/04/msg00133.html

Thank you,
Raphael Geissert
Comment 1 Jarosław Staniek 2012-04-24 19:52:24 UTC
Scripts from kexi/tools/ are obsolete and are no longer installed.