Bug 231916

Summary:	[Testcase] Native KFileDialogs on Windows broken when non-modal
Product:	[Unmaintained] kfile	Reporter:	Thomas Friedrichsmeier <thomas.friedrichsmeier>
Component:	general	Assignee:	KDE-Windows <kde-windows>
Status:	RESOLVED UNMAINTAINED
Severity:	normal	CC:	nate
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Microsoft Windows
OS:	Microsoft Windows
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Thomas Friedrichsmeier 2010-03-23 17:24:30 UTC

Version:            (using KDE 4.4.1)
Installed from:    MS Windows

Native KFileDialogs on Windows are not usable when shown non-modally.

I.e.
KFileDialog::exec() works,
KFileDialog::show() does not.

Testcase:
See attachment #42205 [details] on bug #231913 .

1) In System settings->Advanced->Platform check "Use native system file dialogs".
2) In the testcase application, click the third button from the top. The dialog appears but the layout is completely broken (and as far as it is recognizable at all, it is a non-native dialog).
3) Click the second button (almost the same dialog, but modal). Dialog works as expected.
3) Uncheck "Use native system file dialogs" and restart the test application.
4) Click the third button. Dialog works as expected.

Comment 1 Nate Graham 2018-04-13 16:40:12 UTC

Is this still an issue with KDE Frameworks 5.44 or greater?

Comment 2 Thomas Friedrichsmeier 2018-04-13 19:53:17 UTC

Yes, this bug is still present (in KF5 5.43; let's not be silly in asking for the very latest, or it didn't happen).

For an updated (KF5) testcase, see https://bugs.kde.org/show_bug.cgi?id=231915#c2

Comment 3 Nate Graham 2018-04-16 18:52:27 UTC

I'm afraid we won't be able to address this, as the KDE4 stuff has been unsupported for several years.

Comment 4 Thomas Friedrichsmeier 2018-04-16 18:55:53 UTC

Again, I won't object to WONTFIX, but UNMAINTAINED makes me worry that you did not understand what I am saying:

KFileDialog is _in KF5_, although only in the kdelibs4support framework. It is still suffering the bug, there.

Clearly kdelibs4support is not getting much attention, but as far as I am aware it is maintained, and here to stay for all of the KF5 life time.

Comment 5 Nate Graham 2018-04-16 19:03:21 UTC

Yes, it may be in KF5, but it is there for compatibility with old KDE4 kdelibs code. With either WONTFIX or UNMAINTAINED, the bottom line is the same: software should be ported away from requiring this compatibility code, and our limited resources preclude making these kinds of fixes. Of course, should you (or anyone else) submit a patch, we're happy to take a look at it.

Comment 6 Thomas Friedrichsmeier 2018-04-16 19:08:00 UTC

Ok, fine. No objections to that. But as a suggestion, the next time you ask a reported whether they can still reproduce a problem in a kdelibs4support-class, you could state that a bit clearer upfront.

It's not like updating the testcase and testing on a secondary platform does _not_ cost any time.

Comment 7 Nate Graham 2018-04-16 19:12:26 UTC

Noted, thanks for the suggestion. I'm sorry for the unsatisfactory outcome, even after you submitted a model bug report! We're trying to get better about our bug triaging, which is why I'm going through 8 year-old reports like this one...