Bug 231315

Summary:	Places' Add Entry using wrong item (right-click on non-selected item)
Product:	[Unmaintained] kfile	Reporter:	Per Ångström <per.angstrom>
Component:	kfileplacesview	Assignee:	Peter Penz <peter.penz19>
Status:	RESOLVED FIXED
Severity:	normal	CC:	frank78ac, j.maceachern, rakuco
Priority:	NOR	Keywords:	junior-jobs
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:		Version Fixed In:	4.6.0
Sentry Crash Report:

Description Per Ångström 2010-03-19 15:05:29 UTC

Version:            (using KDE 4.4.1)
Installed from:    openSUSE RPMs

How to reproduce:
1) In the Places panel, select Root.
2) With the mouse, right-click Network. You should now have the context menu for Network open.
3) Select Add Entry.
4) Inspect the Edit Places Entry dialog that comes up.

Expected result: Location should be "remote:/".

Actual result: Location is "/".

In other words, the behavior is as if I had right-clicked the currently selected item (Root). This is perhaps not very serious, since the existing item is not modified, but it is confusing.

Comment 1 Frank Reininghaus 2010-03-19 15:26:08 UTC

Thanks for the report! IMHO, this is not a bug: If you select "Add Entry..." in the context menu of the Places Panel, the default "Location" in the dialog is the current folder, which happens to be "/" in your case.

If I understand you correctly, you expect that the default "Location" in the dialog is the one of the entry you clicked on the Places Panel. However, it is rather pointless to add an entry which is already there, isn't it?

Comment 2 Per Ångström 2010-03-19 15:41:57 UTC

On second though, I think an empty Location field is what should be 
expected; you are right about it being pointless adding a second entry 
pointing to the same location.

Showing the location of another item than the one I right-clicked made 
me think something was wrong. We have had other 
focus-and-context-menu-related bugs in Places, as you may remember.

Comment 3 Per Ångström 2010-03-19 15:47:09 UTC

Also, since the dialog is named "Edit Places Entry", I thought that I 
was modifying an entry, not adding a new one. IMO, the dialog should 
have another name when in add mode.

Comment 4 Per Ångström 2010-03-19 15:52:08 UTC

On third thought... You are of course right: It makes a lot of sense to 
default to the current directory.

Comment 5 Peter Penz 2010-03-20 20:18:09 UTC

I think what should be fixed is the issue from comment #3 with the confusing dialog name.

Comment 6 Per Ångström 2010-10-05 14:27:20 UTC

No apparent change in KDE 4.5.1 with regard to the dialog name.

Comment 7 Jeffery MacEachern 2010-11-21 03:29:43 UTC

The dialog naming issue is fixed in r1199217 (about an hour ago).  I don't have permissions to close this bug.

Comment 8 Raphael Kubo da Costa 2010-11-21 03:41:31 UTC

As for the Bugzilla permissions, please file a sysadmin bug report or try asking for more karma on #kde-bugs.