Bug 231241

Summary: HTTP Authorization Dialog cuts hostname in site display
Product: [Frameworks and Libraries] kdelibs Reporter: Martin Koller <kollix>
Component: kdeuiAssignee: kdelibs bugs <kdelibs-bugs>
Status: RESOLVED FIXED    
Severity: normal CC: cfeck, dave, jp7677, martin.hohenberg
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: openSUSE   
OS: Linux   
Latest Commit: Version Fixed In:
Attachments: screenshot of dialog
proposed fix

Description Martin Koller 2010-03-18 18:04:00 UTC 
Version:            (using KDE 4.4.1)
OS:                Linux
Installed from:    openSUSE RPMs

When I connect to a HTTP Server with konqueror which need authentication, the Authorization Dialog pops up.
This dialog shows "Site:" ... etc.
The Site: value contains here a 2 line output:

AT3.9@eiwrk039
at localhost

The second line only the half height is shown, the bottom half is covered with the LineEdit input field "Username" below.

See attached scrrenshot.
Comment 1 Martin Koller 2010-03-18 18:04:58 UTC 
Created attachment 41742 [details]
screenshot of dialog
Comment 2 Christoph Feck 2010-05-11 00:15:23 UTC 
*** Bug 237135 has been marked as a duplicate of this bug. ***
Comment 3 jens 2010-05-19 20:25:14 UTC 
Same result here (KDE trunk from 18-05-2010), when accessing a site with NTLM authentication the dialog shows:
NTLM at
<server>
whereas <server> is completely hidden in my case.

The problem lives somewhere in http://websvn.kde.org/trunk/KDE/kdelibs/kdeui/dialogs/kpassworddialog.cpp?view=markup in function KPasswordDialog::addCommentLine. Unfortunately I don't know QT well enough to follow the logic :(
Comment 4 Christoph Feck 2010-05-19 21:54:47 UTC 
Created attachment 43741 [details]
proposed fix

There is still some regression with too wide window, but should fix the issue. Please give feedback.
Comment 5 jens 2010-05-19 22:49:40 UTC 
The attached patch works fine for me, the comment is fully visible now, really cool! 
(as you alreaady noted, the dialog is now indeed to wide.)
Comment 6 Christoph Feck 2010-05-20 18:05:56 UTC 
Thanks for testing Jens. I will try to improve the patch to get it into 4.5.
Comment 7 Christoph Feck 2010-06-07 23:33:10 UTC 
*** Bug 132858 has been marked as a duplicate of this bug. ***
Comment 8 Christoph Feck 2010-06-16 01:00:13 UTC 
SVN commit 1138399 by cfeck:

Fix size limits when word wrapped comment lines are added

BUG: 231241


 M  +8 -3      kpassworddialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1138399