Bug 230740

Summary:	[patch] Timers for notification timeouts are newer killed (stopped)
Product:	[Plasma] plasma4	Reporter:	Stefan Brüns <stefan.bruens>
Component:	notifications	Assignee:	Plasma Bugs List <plasma-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	andresbajotierra, aseigo, asraniel, notmart, plasma-bugs
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	openSUSE
OS:	Unspecified
Latest Commit:		Version Fixed In:
Attachments:	add missing killTimer call

Description Stefan Brüns 2010-03-14 18:22:35 UTC

Version:            (using KDE 4.4.1)
Installed from:    openSUSE RPMs

the notificationsengine is missing a killTimer(id) on timeout. Therefore, every new notification creates a timer which is newer stopped.

How to reproduce:
1a) start plasma-desktop with QT_DEBUG_TIMER=1 (requires libqt patch, available e.g on openSUSE)
or 1b) use "strace -epoll -p <plasma-desktop-pid>

2) create a few notification, e.g. with qdbusviewer

3a) should report fired timers from "Application Notification", always reoccuring
3b) numbers of polls will increase, with shorter timeouts for every notification created

Comment 1 Stefan Brüns 2010-03-14 18:26:02 UTC

Created attachment 41625 [details]
add missing killTimer call

Comment 2 Beat Wolf 2010-05-05 14:34:03 UTC

Could you submit this to reviewboard.kde.org ? or the plasma mailing list? with nearly 1000 open plasma bugs this could easely get lost here.

Comment 3 Aaron J. Seigo 2010-05-05 20:09:39 UTC

SVN commit 1123255 by aseigo:

stop the timer; patch by Stefan Brüns
BUG:230740


 M  +1 -0      notificationsengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1123255

Comment 4 Aaron J. Seigo 2010-05-05 20:11:00 UTC

thanks for the patch; and yes, submitting patches via review-board.kde.org is often a better way to ensure the patch does not get lost.. in any case, it's in now. thanks again! :)

Comment 5 Aaron J. Seigo 2010-05-05 20:11:19 UTC

SVN commit 1123257 by aseigo:

stop the timer; patch by Stefan Br?\195?\188ns
BUG:230740


 M  +1 -0      notificationsengine.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1123257