Summary: | No warning when renaming folders with slashes | ||
---|---|---|---|
Product: | [Unmaintained] kmail | Reporter: | Ronny Standtke <Ronny.Standtke> |
Component: | new folder tree | Assignee: | kdepim bugs <kdepim-bugs> |
Status: | RESOLVED FIXED | ||
Severity: | normal | CC: | montel |
Priority: | NOR | ||
Version: | 1.13.1 | ||
Target Milestone: | --- | ||
Platform: | Ubuntu | ||
OS: | Unspecified | ||
Latest Commit: | Version Fixed In: | 4.7.2 | |
Sentry Crash Report: |
Description
Ronny Standtke
2010-03-14 11:54:00 UTC
SVN commit 1170985 by mlaurent: Fix bug #230680 BUG: 230680 No merge in trunk code is not the same. M +1 -1 kmailicalifaceimpl.cpp M +7 -7 kmfolder.cpp M +1 -1 kmfolder.h M +4 -0 kmfolderdialog.cpp M +1 -1 newfolderdialog.cpp WebSVN link: http://websvn.kde.org/?view=rev&revision=1170985 I just tested with KDE-4.6 and the issue is still there, just slightly different: When creating a new folder and using a slash in the folder's name, Kontact gives the error message, when renaming a folder via its properties and using a slash in the name, the slash is silently discarded. This is inconsistent and confusing. The behaviour should be the same with both actions, either show a warning message in both cases or remove this internal restriction. Git commit 8c6a23d462c6a6dde2ea225865fc872a04a5cf23 by Montel Laurent. Committed on 14/09/2011 at 16:23. Pushed by mlaurent into branch 'master'. Add info that we can't add '/' in folder name BUG:230680 M +9 -2 akonadi/standardactionmanager.cpp http://commits.kde.org/kdepimlibs/8c6a23d462c6a6dde2ea225865fc872a04a5cf23 Git commit e0afb8152b2cee153df0735adebb7e098473df3a by Montel Laurent. Committed on 14/09/2011 at 16:24. Pushed by mlaurent into branch 'master'. Add visual info to signal that we can't rename folder to empty string or we can't have "/" in name. FIXED-IN: 4.7.2 BUG: 230680 M +20 -1 mailcommon/collectiongeneralpage.cpp M +1 -0 mailcommon/collectiongeneralpage.h http://commits.kde.org/kdepim/e0afb8152b2cee153df0735adebb7e098473df3a Git commit 92c7fe82d3964dcce31adfaf6fedc66e890ae6cf by Montel Laurent. Committed on 14/09/2011 at 16:24. Pushed by mlaurent into branch '4.7'. Add visual info to signal that we can't rename folder to empty string or we can't have "/" in name. FIXED-IN: 4.7.2 BUG: 230680 (cherry picked from commit e0afb8152b2cee153df0735adebb7e098473df3a) M +20 -1 mailcommon/collectiongeneralpage.cpp M +1 -0 mailcommon/collectiongeneralpage.h http://commits.kde.org/kdepim/92c7fe82d3964dcce31adfaf6fedc66e890ae6cf I can't add new i18n in 4.7 so I add this messagebox in 4.8 to signal that we can't add a name with "/". And I don't want to add new kmessagebox when we rename it => I add a visual effect 'red color when name is bad' It's enough I think. |