Bug 229611

Summary: kopete always connects with empty password for protocols with blank passwords allowed, even if password is saved in config
Product: [Unmaintained] kopete Reporter: H.H. <cyberbeat>
Component: generalAssignee: Kopete Developers <kopete-bugs-null>
Status: RESOLVED WORKSFORME    
Severity: normal    
Priority: NOR    
Version First Reported In: unspecified   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description H.H. 2010-03-05 21:06:33 UTC
Version:           1.0.0 (using 4.4.00 (KDE 4.4.0) "release 222", KDE:KDE4:Factory:Desktop / openSUSE_11.2)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.31.5-0.1-desktop

I think I found the problem in websvn in file kopetepasswordedaccount.cpp (see my comments, I am still not sure):

55 void Kopete::PasswordedAccount::connect( const Kopete::OnlineStatus& initialStatus )
56	{
57	       
58	        d->initialStatus = initialStatus;

// here I think the password is not filled initially:
59	        QString cached = password().cachedValue();

// so, "cached" is allways empty, and for normal accounts this is skipped
// but for my irc protocol with empty passwords allowed this is always true, and a password dialog will never be shown, and so the cached value will always be empty?
60	        if( !cached.isNull() || d->password.allowBlankPassword() )
61	        {
62	                connectWithPassword( cached );
63	                return;
64	        }
65	
66	        QString prompt = passwordPrompt();

//here the password is fetched from config, so the cache is filled.
//I think the allowBlankPassword-Case should be handled here instead of above
67	        Kopete::Password::PasswordSource src = password().isWrong() ? Kopete::Password::FromUser : Kopete::Password::FromConfigOrUser;
68	
69	        password().request( this, SLOT( connectWithPassword( const QString & ) ), accountIcon( Kopete::Password::preferredImageSize() ), prompt, src );
70	}
Comment 1 Andrew Crouthamel 2018-11-02 22:59:25 UTC
Dear Bug Submitter,

This bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version? I am setting the status to NEEDSINFO pending your response, please change the Status back to REPORTED when you respond.

Thank you for helping us make KDE software even better for everyone!
Comment 2 Andrew Crouthamel 2018-11-16 05:32:51 UTC
Dear Bug Submitter,

This is a reminder that this bug has been stagnant for a long time. Could you help us out and re-test if the bug is valid in the latest version?

Thank you for helping us make KDE software even better for everyone!
Comment 3 Justin Zobel 2022-12-12 01:56:01 UTC
Thank you for reporting this issue in KDE software. As it has been a while since this issue was reported, can we please ask you to see if you can reproduce the issue with a recent software version?

If you can reproduce the issue, please change the status to "REPORTED" when replying. Thank you!
Comment 4 Bug Janitor Service 2022-12-27 05:21:21 UTC
Dear Bug Submitter,

This bug has been in NEEDSINFO status with no change for at least
15 days. Please provide the requested information as soon as
possible and set the bug status as REPORTED. Due to regular bug
tracker maintenance, if the bug is still in NEEDSINFO status with
no change in 30 days the bug will be closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

If you have already provided the requested information, please
mark the bug as REPORTED so that the KDE team knows that the bug is
ready to be confirmed.

Thank you for helping us make KDE software even better for everyone!
Comment 5 Bug Janitor Service 2023-01-11 05:19:17 UTC
This bug has been in NEEDSINFO status with no change for at least
30 days. The bug is now closed as RESOLVED > WORKSFORME
due to lack of needed information.

For more information about our bug triaging procedures please read the
wiki located here:
https://community.kde.org/Guidelines_and_HOWTOs/Bug_triaging

Thank you for helping us make KDE software even better for everyone!