Summary: | Crash after adding and upon startup the next time [Amarok2ConfigDialog::updateSettings] | ||
---|---|---|---|
Product: | [Applications] amarok | Reporter: | José Alejandro Carrillo Neira <j.alec.n> |
Component: | general | Assignee: | Amarok Developers <amarok-bugs-dist> |
Status: | RESOLVED WORKSFORME | ||
Severity: | crash | CC: | CharlesT.TSH, eljefedelito, kretschmann, mr.kryptos |
Priority: | NOR | ||
Version: | 2.3.1 | ||
Target Milestone: | --- | ||
Platform: | Unlisted Binaries | ||
OS: | Linux | ||
Latest Commit: | Version Fixed In: | ||
Sentry Crash Report: |
Description
José Alejandro Carrillo Neira
2010-03-03 13:19:09 UTC
commit ccbc1343545cb93acb4e3cfb02fc4bc2a4af4960 Author: Mark Kretschmann <kretschmann@kde.org> Date: Sun Mar 14 12:47:42 2010 +0100 Try to fix an obscure crash in the config dialog code. I'm not really sure how this crash could happen in the first place, and neither can I reproduce it. However, the problem seems to be a dangling pointer, so our SmartPointerList should cure that. BUG: 229243 diff --git a/src/configdialog/ConfigDialog.h b/src/configdialog/ConfigDialog.h index f1a88f9..ea72e7a 100644 --- a/src/configdialog/ConfigDialog.h +++ b/src/configdialog/ConfigDialog.h @@ -21,6 +21,8 @@ #include <kconfigdialog.h> +#include "SmartPointerList.h" + class Amarok2ConfigDialog : public KConfigDialog { @@ -56,7 +58,7 @@ class Amarok2ConfigDialog : public KConfigDialog bool isDefault(); private: - QList<ConfigDialogBase*> m_pageList; + SmartPointerList<ConfigDialogBase> m_pageList; QMap<ConfigDialogBase*, KPageWidgetItem*> m_pageMap; static QString s_currentPage; Sorry, but it is not fixed, I had the exact same crash with a fresh install in current git build a few minutes ago. Current head is at 352cb0e: Thread 1 (Thread 0x7f2dd5948820 (LWP 669)): [KCrash Handler] #5 0x00007f2dd474d1c0 in Amarok2ConfigDialog::updateSettings (this=0x2e124b0) at /home/myriam/kde/src/amarok/src/configdialog/ConfigDialog.cpp:136 #6 0x00007f2dd52c0101 in KConfigDialog::qt_metacall (this=0x2e124b0, _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>, _a=0x7fffbab43f30) at ./kconfigdialog.moc:91 #7 0x00007f2dd474d7ef in Amarok2ConfigDialog::qt_metacall (this=0x2e124b0, _c=QMetaObject::InvokeMetaMethod, _id=77, _a=0x7fffbab43f30) at /home/myriam/kde/build/amarok/src/ConfigDialog.moc:73 #8 0x00007f2dd30e7dcf in QMetaObject::activate (sender=0x2e124b0, m=<value optimized out>, local_signal_index=<value optimized out>, argv=0x1) at kernel/qobject.cpp:3293 #9 0x00007f2dd52d135a in KDialog::slotButtonClicked (this=0x2e124b0, button=8) at ../../kdeui/dialogs/kdialog.cpp:866 #10 0x00007f2dd52d32e9 in KDialog::qt_metacall (this=0x2e124b0, _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>, _a=0x7fffbab44190) at ./kdialog.moc:190 #11 0x00007f2dd539a790 in KPageDialog::qt_metacall (this=0x32866b0, _c=3132374496, _id=52979376, _a=0x1) at ./kpagedialog.moc:70 #12 0x00007f2dd52c0040 in KConfigDialog::qt_metacall (this=0x32866b0, _c=3132374496, _id=52979376, _a=0x1) at ./kconfigdialog.moc:84 #13 0x00007f2dd474d7ef in Amarok2ConfigDialog::qt_metacall (this=0x2e124b0, _c=QMetaObject::InvokeMetaMethod, _id=69, _a=0x7fffbab44190) at /home/myriam/kde/build/amarok/src/ConfigDialog.moc:73 #14 0x00007f2dd30e7dcf in QMetaObject::activate (sender=0x32fab98, m=<value optimized out>, local_signal_index=<value optimized out>, argv=0x1) at kernel/qobject.cpp:3293 #15 0x00007f2dd30ed0ee in QSignalMapper::mapped (this=0x32866b0, _t1=8) at .moc/release-shared/moc_qsignalmapper.cpp:101 #16 0x00007f2dd30ee302 in QSignalMapper::map (this=0x32fab98, sender=0x3114810) at kernel/qsignalmapper.cpp:266 #17 0x00007f2dd30ee580 in QSignalMapper::qt_metacall (this=0x32fab98, _c=QMetaObject::InvokeMetaMethod, _id=<value optimized out>, _a=0x7fffbab44320) at .moc/release-shared/moc_qsignalmapper.cpp:87 #18 0x00007f2dd30e7dcf in QMetaObject::activate (sender=0x3114810, m=<value optimized out>, local_signal_index=<value optimized out>, argv=0x1) at kernel/qobject.cpp:3293 #19 0x00007f2dd40e9542 in QAbstractButton::clicked (this=0x32866b0, _t1=false) at .moc/release-shared/moc_qabstractbutton.cpp:206 #20 0x00007f2dd3e037db in QAbstractButtonPrivate::emitClicked (this=0x50d71c0) at widgets/qabstractbutton.cpp:546 #21 0x00007f2dd3e0467b in QAbstractButtonPrivate::click (this=0x50d71c0) at widgets/qabstractbutton.cpp:539 #22 0x00007f2dd3e048ec in QAbstractButton::mouseReleaseEvent (this=0x3114810, e=0x7fffbab44c70) at widgets/qabstractbutton.cpp:1121 #23 0x00007f2dd3aa4592 in QWidget::event (this=0x3114810, event=0x7fffbab44c70) at kernel/qwidget.cpp:7998 #24 0x00007f2dd3a4e22c in QApplicationPrivate::notify_helper (this=0x23065c0, receiver=0x3114810, e=0x7fffbab44c70) at kernel/qapplication.cpp:4300 #25 0x00007f2dd3a54edb in QApplication::notify (this=0x7fffbab45920, receiver=0x3114810, e=0x7fffbab44c70) at kernel/qapplication.cpp:3865 #26 0x00007f2dd4af2e62 in App::notify (this=0x7fffbab45920, receiver=0x3114810, event=0x7fffbab44c70) at /home/myriam/kde/src/amarok/src/App.cpp:927 #27 0x00007f2dd30d4ffc in QCoreApplication::notifyInternal (this=0x7fffbab45920, receiver=0x3114810, event=0x7fffbab44c70) at kernel/qcoreapplication.cpp:704 #28 0x00007f2dd3a540ae in QCoreApplication::sendEvent (receiver=0x3114810, event=0x7fffbab44c70, alienWidget=0x3114810, nativeWidget=0x31ab3e0, buttonDown=<value optimized out>, lastMouseReceiver=<value optimized out>, spontaneous=true) at ../../include/QtCore/../../src/corelib/kernel/qcoreapplication.h:215 #29 QApplicationPrivate::sendMouseEvent (receiver=0x3114810, event=0x7fffbab44c70, alienWidget=0x3114810, nativeWidget=0x31ab3e0, buttonDown=<value optimized out>, lastMouseReceiver=<value optimized out>, spontaneous=true) at kernel/qapplication.cpp:2965 #30 0x00007f2dd3ad3f75 in QETWidget::translateMouseEvent (this=0x31ab3e0, event=<value optimized out>) at kernel/qapplication_x11.cpp:4368 #31 0x00007f2dd3ad28bc in QApplication::x11ProcessEvent (this=<value optimized out>, event=0x7fffbab45590) at kernel/qapplication_x11.cpp:3501 #32 0x00007f2dd3afe722 in x11EventSourceDispatch (s=0x2309bb0, callback=<value optimized out>, user_data=<value optimized out>) at kernel/qguieventdispatcher_glib.cpp:146 #33 0x00007f2dcbc67432 in g_main_context_dispatch () from /lib/libglib-2.0.so.0 #34 0x00007f2dcbc6b2b8 in ?? () from /lib/libglib-2.0.so.0 #35 0x00007f2dcbc6b46c in g_main_context_iteration () from /lib/libglib-2.0.so.0 #36 0x00007f2dd30fe4a3 in QEventDispatcherGlib::processEvents (this=0x21b31c0, flags=<value optimized out>) at kernel/qeventdispatcher_glib.cpp:412 #37 0x00007f2dd3afe30e in QGuiEventDispatcherGlib::processEvents (this=0x32866b0, flags=<value optimized out>) at kernel/qguieventdispatcher_glib.cpp:204 #38 0x00007f2dd30d3922 in QEventLoop::processEvents (this=<value optimized out>, flags=) at kernel/qeventloop.cpp:149 #39 0x00007f2dd30d3cfc in QEventLoop::exec (this=0x7fffbab458c0, flags=) at kernel/qeventloop.cpp:201 #40 0x00007f2dd30d7a3b in QCoreApplication::exec () at kernel/qcoreapplication.cpp:981 #41 0x000000000040afb1 in main (argc=4, argv=0x7fffbab47878) at /home/myriam/kde/src/amarok/src/main.cpp:237 commit 7a31ffcefdd5c85fc837daa4ea0823a300e5020f Author: Mark Kretschmann <kretschmann@kde.org> Date: Wed Mar 24 09:50:15 2010 +0100 Revert "Try to fix an obscure crash in the config dialog code." This reverts commit ccbc1343545cb93acb4e3cfb02fc4bc2a4af4960. Turns out that this patch was pointless and didn't fix anything. CCBUG: 229243 diff --git a/src/configdialog/ConfigDialog.h b/src/configdialog/ConfigDialog.h index ea72e7a..f1a88f9 100644 --- a/src/configdialog/ConfigDialog.h +++ b/src/configdialog/ConfigDialog.h @@ -21,8 +21,6 @@ #include <kconfigdialog.h> -#include "SmartPointerList.h" - class Amarok2ConfigDialog : public KConfigDialog { @@ -58,7 +56,7 @@ class Amarok2ConfigDialog : public KConfigDialog bool isDefault(); private: - SmartPointerList<ConfigDialogBase> m_pageList; + QList<ConfigDialogBase*> m_pageList; QMap<ConfigDialogBase*, KPageWidgetItem*> m_pageMap; static QString s_currentPage; This bug is possibly related to Bug 231398 This issue was apparently a KDE bug, should be fixed with the latest KDE version :) *** Bug 250666 has been marked as a duplicate of this bug. *** (In reply to comment #5) > This issue was apparently a KDE bug, should be fixed with the latest KDE > version :) Which version is that? It happens with KDE 4.4.5 Reopening, as it is not clear when and by what this was fixed. Last report was with Amarok 2.3.1 and KDE 4.4.5 *** Bug 256629 has been marked as a duplicate of this bug. *** Any news on this? Please test with Amarok 2.4 *** Bug 244520 has been marked as a duplicate of this bug. *** Closing for lack of feedback. This is likely already solved in Amarok 2.4. Feel free to reopen this report if you can reproduce this with Amarok 2.4 or later. |