Bug 229226

Summary: Can't advance to next random track when searching playlist
Product: [Applications] amarok Reporter: floofeh
Component: generalAssignee: Amarok Bugs <amarok-bugs-null>
Status: RESOLVED FIXED    
Severity: normal CC: nhn
Priority: NOR    
Version First Reported In: 2.2.2   
Target Milestone: ---   
Platform: unspecified   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:

Description floofeh 2010-03-03 10:49:35 UTC 
Version:           2.2.2 (using 4.4.00 (KDE 4.4.0), 4.4.0-9.fc11 Fedora)
Compiler:          gcc
OS:                Linux (x86_64) release 2.6.30.8-64.fc11.x86_64

When I search the playlist during song playback, it refuses to play once that song is over. To get this result, I did the following:

1. Append several songs into the playlist.
2. Set to random, play any song.
3. Type something in the 'search playlist' box.
4. Press the 'next' button: nothing should happen.

If the current song is allowed to finish playing, nothing will come after it. If a song is then chosen from the search options, the song will play, but nothing will come after it.

To fix this problem, the playback options can be changed to 'standard' while in the search options, then back to 'random'. Amarok will then play random songs within the search results. If this is done, once out of the search results, only the songs that were in those search results will play until the options are changed back to 'standard' and to 'random' again.
Comment 1 Nikolaj Hald Nielsen 2010-03-17 16:04:19 UTC 
commit ca11abf622c59ef3d0ec06eca38970e75b95855d
Author: Nanno Langstraat <langstr@gmail.com>
Date:   Tue Mar 16 17:01:37 2010 +0100

    Playlist navigators: refactor based on the new 'NonlinearTrackNavigator' and 'AlbumNavigator'.
    
    Benefits:
      - This is the proper fix for BUG 229226 / 222129.
    
      - Fixes the bug reported in http://mail.kde.org/pipermail/amarok-devel/2010-March/006649.html
    
      - Back/forward in history now works well for all navigators.
    
      - History doesn't get deleted when end of playlist is reached.
    
      - RandomTrackNavigator: no longer a chance of repeating recent tracks when end of
        playlist is crossed.
    
      - Get rid of huge swathes of (near-)duplicated code.
    
      - Uses standard Qt signals, opening the way to getting rid of the redundant (and
        thereby bug-causing) 'insertedIds' signal and its friends.